op public repos

Blame

Date:: Thu Oct 27 09:21:33 2022 UTC
Message:: plug a memory leak on error in got_gotconfig_read() ok op@
Actions:: History | Blob | Raw File
  1 96fd6df1 2022-10-13 stsp /*
  2 96fd6df1 2022-10-13 stsp  * Copyright (c) 2020 Stefan Sperling <stsp@openbsd.org>
  3 96fd6df1 2022-10-13 stsp  *
  4 96fd6df1 2022-10-13 stsp  * Permission to use, copy, modify, and distribute this software for any
  5 96fd6df1 2022-10-13 stsp  * purpose with or without fee is hereby granted, provided that the above
  6 96fd6df1 2022-10-13 stsp  * copyright notice and this permission notice appear in all copies.
  7 96fd6df1 2022-10-13 stsp  *
  8 96fd6df1 2022-10-13 stsp  * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
  9 96fd6df1 2022-10-13 stsp  * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
 10 96fd6df1 2022-10-13 stsp  * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
 11 96fd6df1 2022-10-13 stsp  * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
 12 96fd6df1 2022-10-13 stsp  * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
 13 96fd6df1 2022-10-13 stsp  * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
 14 96fd6df1 2022-10-13 stsp  * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 15 96fd6df1 2022-10-13 stsp  */
 16 96fd6df1 2022-10-13 stsp 
 17 96fd6df1 2022-10-13 stsp #include <sys/types.h>
 18 96fd6df1 2022-10-13 stsp #include <sys/queue.h>
 19 96fd6df1 2022-10-13 stsp #include <sys/uio.h>
 20 96fd6df1 2022-10-13 stsp #include <sys/socket.h>
 21 96fd6df1 2022-10-13 stsp 
 22 96fd6df1 2022-10-13 stsp #include <unistd.h>
 23 96fd6df1 2022-10-13 stsp #include <fcntl.h>
 24 96fd6df1 2022-10-13 stsp #include <errno.h>
 25 96fd6df1 2022-10-13 stsp #include <stdlib.h>
 26 96fd6df1 2022-10-13 stsp #include <stdio.h>
 27 96fd6df1 2022-10-13 stsp #include <stdint.h>
 28 96fd6df1 2022-10-13 stsp #include <imsg.h>
 29 96fd6df1 2022-10-13 stsp #include <sha1.h>
 30 96fd6df1 2022-10-13 stsp #include <limits.h>
 31 96fd6df1 2022-10-13 stsp 
 32 96fd6df1 2022-10-13 stsp #include "got_error.h"
 33 96fd6df1 2022-10-13 stsp #include "got_object.h"
 34 96fd6df1 2022-10-13 stsp #include "got_repository.h"
 35 96fd6df1 2022-10-13 stsp 
 36 96fd6df1 2022-10-13 stsp #include "got_lib_delta.h"
 37 96fd6df1 2022-10-13 stsp #include "got_lib_object.h"
 38 96fd6df1 2022-10-13 stsp #include "got_lib_privsep.h"
 39 96fd6df1 2022-10-13 stsp #include "got_lib_gotconfig.h"
 40 96fd6df1 2022-10-13 stsp 
 41 96fd6df1 2022-10-13 stsp #include "got_gotconfig.h"
 42 96fd6df1 2022-10-13 stsp 
 43 96fd6df1 2022-10-13 stsp const struct got_error *
 44 96fd6df1 2022-10-13 stsp got_gotconfig_read(struct got_gotconfig **conf, const char *gotconfig_path)
 45 96fd6df1 2022-10-13 stsp {
 46 96fd6df1 2022-10-13 stsp 	const struct got_error *err = NULL, *child_err = NULL;
 47 96fd6df1 2022-10-13 stsp 	int fd = -1;
 48 96fd6df1 2022-10-13 stsp 	int imsg_fds[2] = { -1, -1 };
 49 96fd6df1 2022-10-13 stsp 	pid_t pid;
 50 41725847 2022-10-27 stsp 	struct imsgbuf *ibuf = NULL;
 51 96fd6df1 2022-10-13 stsp 
 52 96fd6df1 2022-10-13 stsp 	*conf = calloc(1, sizeof(**conf));
 53 96fd6df1 2022-10-13 stsp 	if (*conf == NULL)
 54 96fd6df1 2022-10-13 stsp 		return got_error_from_errno("calloc");
 55 96fd6df1 2022-10-13 stsp 
 56 96fd6df1 2022-10-13 stsp 	fd = open(gotconfig_path, O_RDONLY | O_CLOEXEC);
 57 96fd6df1 2022-10-13 stsp 	if (fd == -1) {
 58 96fd6df1 2022-10-13 stsp 		if (errno == ENOENT)
 59 96fd6df1 2022-10-13 stsp 			return NULL;
 60 41725847 2022-10-27 stsp 		err = got_error_from_errno2("open", gotconfig_path);
 61 41725847 2022-10-27 stsp 		goto done;
 62 96fd6df1 2022-10-13 stsp 	}
 63 96fd6df1 2022-10-13 stsp 
 64 96fd6df1 2022-10-13 stsp 	ibuf = calloc(1, sizeof(*ibuf));
 65 96fd6df1 2022-10-13 stsp 	if (ibuf == NULL) {
 66 96fd6df1 2022-10-13 stsp 		err = got_error_from_errno("calloc");
 67 96fd6df1 2022-10-13 stsp 		goto done;
 68 96fd6df1 2022-10-13 stsp 	}
 69 96fd6df1 2022-10-13 stsp 
 70 96fd6df1 2022-10-13 stsp 	if (socketpair(AF_UNIX, SOCK_STREAM, PF_UNSPEC, imsg_fds) == -1) {
 71 96fd6df1 2022-10-13 stsp 		err = got_error_from_errno("socketpair");
 72 96fd6df1 2022-10-13 stsp 		goto done;
 73 96fd6df1 2022-10-13 stsp 	}
 74 96fd6df1 2022-10-13 stsp 
 75 96fd6df1 2022-10-13 stsp 	pid = fork();
 76 96fd6df1 2022-10-13 stsp 	if (pid == -1) {
 77 96fd6df1 2022-10-13 stsp 		err = got_error_from_errno("fork");
 78 96fd6df1 2022-10-13 stsp 		goto done;
 79 96fd6df1 2022-10-13 stsp 	} else if (pid == 0) {
 80 96fd6df1 2022-10-13 stsp 		got_privsep_exec_child(imsg_fds, GOT_PATH_PROG_READ_GOTCONFIG,
 81 96fd6df1 2022-10-13 stsp 		    gotconfig_path);
 82 96fd6df1 2022-10-13 stsp 		/* not reached */
 83 96fd6df1 2022-10-13 stsp 	}
 84 96fd6df1 2022-10-13 stsp 
 85 96fd6df1 2022-10-13 stsp 	if (close(imsg_fds[1]) == -1) {
 86 96fd6df1 2022-10-13 stsp 		err = got_error_from_errno("close");
 87 96fd6df1 2022-10-13 stsp 		goto done;
 88 96fd6df1 2022-10-13 stsp 	}
 89 96fd6df1 2022-10-13 stsp 	imsg_fds[1] = -1;
 90 96fd6df1 2022-10-13 stsp 	imsg_init(ibuf, imsg_fds[0]);
 91 96fd6df1 2022-10-13 stsp 
 92 96fd6df1 2022-10-13 stsp 	err = got_privsep_send_gotconfig_parse_req(ibuf, fd);
 93 96fd6df1 2022-10-13 stsp 	if (err)
 94 96fd6df1 2022-10-13 stsp 		goto done;
 95 96fd6df1 2022-10-13 stsp 	fd = -1;
 96 96fd6df1 2022-10-13 stsp 
 97 96fd6df1 2022-10-13 stsp 	err = got_privsep_send_gotconfig_author_req(ibuf);
 98 96fd6df1 2022-10-13 stsp 	if (err)
 99 96fd6df1 2022-10-13 stsp 		goto done;
100 96fd6df1 2022-10-13 stsp 
101 96fd6df1 2022-10-13 stsp 	err = got_privsep_recv_gotconfig_str(&(*conf)->author, ibuf);
102 96fd6df1 2022-10-13 stsp 	if (err)
103 96fd6df1 2022-10-13 stsp 		goto done;
104 96fd6df1 2022-10-13 stsp 
105 96fd6df1 2022-10-13 stsp 	err = got_privsep_send_gotconfig_allowed_signers_req(ibuf);
106 96fd6df1 2022-10-13 stsp 	if (err)
107 96fd6df1 2022-10-13 stsp 		goto done;
108 96fd6df1 2022-10-13 stsp 
109 96fd6df1 2022-10-13 stsp 	err = got_privsep_recv_gotconfig_str(&(*conf)->allowed_signers_file,
110 96fd6df1 2022-10-13 stsp 	    ibuf);
111 96fd6df1 2022-10-13 stsp 	if (err)
112 96fd6df1 2022-10-13 stsp 		goto done;
113 96fd6df1 2022-10-13 stsp 
114 96fd6df1 2022-10-13 stsp 	err = got_privsep_send_gotconfig_revoked_signers_req(ibuf);
115 96fd6df1 2022-10-13 stsp 	if (err)
116 96fd6df1 2022-10-13 stsp 		goto done;
117 96fd6df1 2022-10-13 stsp 
118 96fd6df1 2022-10-13 stsp 	err = got_privsep_recv_gotconfig_str(&(*conf)->revoked_signers_file,
119 96fd6df1 2022-10-13 stsp 	    ibuf);
120 96fd6df1 2022-10-13 stsp 	if (err)
121 96fd6df1 2022-10-13 stsp 		goto done;
122 96fd6df1 2022-10-13 stsp 
123 96fd6df1 2022-10-13 stsp 	err = got_privsep_send_gotconfig_signer_id_req(ibuf);
124 96fd6df1 2022-10-13 stsp 	if (err)
125 96fd6df1 2022-10-13 stsp 		goto done;
126 96fd6df1 2022-10-13 stsp 
127 96fd6df1 2022-10-13 stsp 	err = got_privsep_recv_gotconfig_str(&(*conf)->signer_id, ibuf);
128 96fd6df1 2022-10-13 stsp 	if (err)
129 96fd6df1 2022-10-13 stsp 		goto done;
130 96fd6df1 2022-10-13 stsp 
131 96fd6df1 2022-10-13 stsp 	err = got_privsep_send_gotconfig_remotes_req(ibuf);
132 96fd6df1 2022-10-13 stsp 	if (err)
133 96fd6df1 2022-10-13 stsp 		goto done;
134 96fd6df1 2022-10-13 stsp 
135 96fd6df1 2022-10-13 stsp 	err = got_privsep_recv_gotconfig_remotes(&(*conf)->remotes,
136 96fd6df1 2022-10-13 stsp 	    &(*conf)->nremotes, ibuf);
137 96fd6df1 2022-10-13 stsp 	if (err)
138 96fd6df1 2022-10-13 stsp 		goto done;
139 96fd6df1 2022-10-13 stsp 
140 96fd6df1 2022-10-13 stsp 	err = got_privsep_send_stop(imsg_fds[0]);
141 96fd6df1 2022-10-13 stsp 	child_err = got_privsep_wait_for_child(pid);
142 96fd6df1 2022-10-13 stsp 	if (child_err && err == NULL)
143 96fd6df1 2022-10-13 stsp 		err = child_err;
144 96fd6df1 2022-10-13 stsp done:
145 96fd6df1 2022-10-13 stsp 	if (imsg_fds[0] != -1 && close(imsg_fds[0]) == -1 && err == NULL)
146 96fd6df1 2022-10-13 stsp 		err = got_error_from_errno("close");
147 96fd6df1 2022-10-13 stsp 	if (imsg_fds[1] != -1 && close(imsg_fds[1]) == -1 && err == NULL)
148 96fd6df1 2022-10-13 stsp 		err = got_error_from_errno("close");
149 96fd6df1 2022-10-13 stsp 	if (fd != -1 && close(fd) == -1 && err == NULL)
150 96fd6df1 2022-10-13 stsp 		err = got_error_from_errno2("close", gotconfig_path);
151 96fd6df1 2022-10-13 stsp 	if (err) {
152 96fd6df1 2022-10-13 stsp 		got_gotconfig_free(*conf);
153 96fd6df1 2022-10-13 stsp 		*conf = NULL;
154 96fd6df1 2022-10-13 stsp 	}
155 96fd6df1 2022-10-13 stsp 	free(ibuf);
156 96fd6df1 2022-10-13 stsp 	return err;
157 96fd6df1 2022-10-13 stsp }