Blame

Date:
Message:
malloc: remove locking The issue manifests in fork: POSIX fork mandates that a fork'd process is created with a single thread. If a multithreaded program forks, and some thread was in malloc() when the fork() happened, then in the child the lock will be held but there will be no thread to release it. We assume the system malloc() must already know how to deal with this and is thread-safe, but it won't know about our custom spinlock. Judging that this is no longer necessary (the lock code was added 15 years ago) we remove it. Signed-off-by: Dan Cross <cross@gajendra.net>
Actions:
History | Blob | Raw File
 1 9c635587 2004-06-09 devnull /*

 2 9c635587 2004-06-09 devnull  * These are here mainly so that I can link against

 3 9c635587 2004-06-09 devnull  * debugmalloc.c instead and not recompile the world.

 4 9c635587 2004-06-09 devnull  */

 5 9c635587 2004-06-09 devnull 

 6 b3994ec5 2003-12-11 devnull #include <u.h>

 7 b3994ec5 2003-12-11 devnull #define NOPLAN9DEFINES

 8 b3994ec5 2003-12-11 devnull #include <libc.h>

 9 b3994ec5 2003-12-11 devnull 

10 8be32ce2 2005-07-14 devnull 

11 b3994ec5 2003-12-11 devnull void*

12 b3994ec5 2003-12-11 devnull p9malloc(ulong n)

13 b3994ec5 2003-12-11 devnull {

14 b3994ec5 2003-12-11 devnull 	if(n == 0)

15 b3994ec5 2003-12-11 devnull 		n++;

16 7bf2db4c 2020-01-16 cross 	return malloc(n);

17 b3994ec5 2003-12-11 devnull }

18 7e0e6522 2004-05-23 devnull 

19 7e0e6522 2004-05-23 devnull void

20 7e0e6522 2004-05-23 devnull p9free(void *v)

21 7e0e6522 2004-05-23 devnull {

22 7e0e6522 2004-05-23 devnull 	free(v);

23 7e0e6522 2004-05-23 devnull }

24 7e0e6522 2004-05-23 devnull 

25 7e0e6522 2004-05-23 devnull void*

26 7e0e6522 2004-05-23 devnull p9calloc(ulong a, ulong b)

27 7e0e6522 2004-05-23 devnull {

28 9c635587 2004-06-09 devnull 	if(a*b == 0)

29 9c635587 2004-06-09 devnull 		a = b = 1;

30 7bf2db4c 2020-01-16 cross 	return calloc(a, b);

31 7e0e6522 2004-05-23 devnull }

32 7e0e6522 2004-05-23 devnull 

33 7e0e6522 2004-05-23 devnull void*

34 7e0e6522 2004-05-23 devnull p9realloc(void *v, ulong n)

35 7e0e6522 2004-05-23 devnull {

36 7bf2db4c 2020-01-16 cross 	return realloc(v, n);

37 7e0e6522 2004-05-23 devnull }