op public repos

Blob

Date:: Tue Aug 13 15:01:23 2019 UTC
Message:: properly parse timestamps in commit objects as UTC (patch by Hiltjo Posthuma)
Actions:: History | Blame | Raw File
1 /*
2  * Copyright (c) 2018, 2019 Stefan Sperling <stsp@openbsd.org>
3  *
4  * Permission to use, copy, modify, and distribute this software for any
5  * purpose with or without fee is hereby granted, provided that the above
6  * copyright notice and this permission notice appear in all copies.
7  *
8  * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
9  * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
10  * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
11  * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
12  * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
13  * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
14  * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
15  */
16 
17 #include <sys/types.h>
18 #include <sys/stat.h>
19 #include <sys/queue.h>
20 #include <sys/uio.h>
21 #include <sys/socket.h>
22 #include <sys/syslimits.h>
23 #include <sys/wait.h>
24 
25 #include <errno.h>
26 #include <stdio.h>
27 #include <stdlib.h>
28 #include <string.h>
29 #include <stdint.h>
30 #include <sha1.h>
31 #include <zlib.h>
32 #include <ctype.h>
33 #include <limits.h>
34 #include <imsg.h>
35 #include <time.h>
36 #include <unistd.h>
37 
38 #include "got_error.h"
39 #include "got_object.h"
40 #include "got_repository.h"
41 #include "got_opentemp.h"
42 #include "got_path.h"
43 
44 #include "got_lib_sha1.h"
45 #include "got_lib_delta.h"
46 #include "got_lib_inflate.h"
47 #include "got_lib_object.h"
48 #include "got_lib_object_cache.h"
49 #include "got_lib_pack.h"
50 #include "got_lib_privsep.h"
51 #include "got_lib_repository.h"
52 
53 #ifndef nitems
54 #define nitems(_a) (sizeof(_a) / sizeof((_a)[0]))
55 #endif
56 
57 int
58 got_object_id_cmp(const struct got_object_id *id1,
59     const struct got_object_id *id2)
60 {
61 	return memcmp(id1->sha1, id2->sha1, SHA1_DIGEST_LENGTH);
62 }
63 
64 const struct got_error *
65 got_object_qid_alloc_partial(struct got_object_qid **qid)
66 {
67 	const struct got_error *err = NULL;
68 
69 	*qid = malloc(sizeof(**qid));
70 	if (*qid == NULL)
71 		return got_error_from_errno("malloc");
72 
73 	(*qid)->id = malloc(sizeof(*((*qid)->id)));
74 	if ((*qid)->id == NULL) {
75 		err = got_error_from_errno("malloc");
76 		got_object_qid_free(*qid);
77 		*qid = NULL;
78 		return err;
79 	}
80 
81 	return NULL;
82 }
83 
84 const struct got_error *
85 got_object_id_str(char **outbuf, struct got_object_id *id)
86 {
87 	static const size_t len = SHA1_DIGEST_STRING_LENGTH;
88 
89 	*outbuf = malloc(len);
90 	if (*outbuf == NULL)
91 		return got_error_from_errno("malloc");
92 
93 	if (got_sha1_digest_to_str(id->sha1, *outbuf, len) == NULL) {
94 		free(*outbuf);
95 		*outbuf = NULL;
96 		return got_error(GOT_ERR_BAD_OBJ_ID_STR);
97 	}
98 
99 	return NULL;
100 }
101 
102 void
103 got_object_close(struct got_object *obj)
104 {
105 	if (obj->refcnt > 0) {
106 		obj->refcnt--;
107 		if (obj->refcnt > 0)
108 			return;
109 	}
110 
111 	if (obj->flags & GOT_OBJ_FLAG_DELTIFIED) {
112 		struct got_delta *delta;
113 		while (!SIMPLEQ_EMPTY(&obj->deltas.entries)) {
114 			delta = SIMPLEQ_FIRST(&obj->deltas.entries);
115 			SIMPLEQ_REMOVE_HEAD(&obj->deltas.entries, entry);
116 			free(delta->delta_buf);
117 			free(delta);
118 		}
119 	}
120 	if (obj->flags & GOT_OBJ_FLAG_PACKED)
121 		free(obj->path_packfile);
122 	free(obj);
123 }
124 
125 void
126 got_object_qid_free(struct got_object_qid *qid)
127 {
128 	free(qid->id);
129 	free(qid);
130 }
131 
132 void
133 got_object_id_queue_free(struct got_object_id_queue *ids)
134 {
135 	struct got_object_qid *qid;
136 
137 	while (!SIMPLEQ_EMPTY(ids)) {
138 		qid = SIMPLEQ_FIRST(ids);
139 		SIMPLEQ_REMOVE_HEAD(ids, entry);
140 		got_object_qid_free(qid);
141 	}
142 }
143 
144 const struct got_error *
145 got_object_parse_header(struct got_object **obj, char *buf, size_t len)
146 {
147 	const char *obj_labels[] = {
148 		GOT_OBJ_LABEL_COMMIT,
149 		GOT_OBJ_LABEL_TREE,
150 		GOT_OBJ_LABEL_BLOB,
151 		GOT_OBJ_LABEL_TAG,
152 	};
153 	const int obj_types[] = {
154 		GOT_OBJ_TYPE_COMMIT,
155 		GOT_OBJ_TYPE_TREE,
156 		GOT_OBJ_TYPE_BLOB,
157 		GOT_OBJ_TYPE_TAG,
158 	};
159 	int type = 0;
160 	size_t size = 0, hdrlen = 0;
161 	int i;
162 
163 	*obj = NULL;
164 
165 	hdrlen = strnlen(buf, len) + 1 /* '\0' */;
166 	if (hdrlen > len)
167 		return got_error(GOT_ERR_BAD_OBJ_HDR);
168 
169 	for (i = 0; i < nitems(obj_labels); i++) {
170 		const char *label = obj_labels[i];
171 		size_t label_len = strlen(label);
172 		const char *errstr;
173 
174 		if (strncmp(buf, label, label_len) != 0)
175 			continue;
176 
177 		type = obj_types[i];
178 		if (len <= label_len)
179 			return got_error(GOT_ERR_BAD_OBJ_HDR);
180 		size = strtonum(buf + label_len, 0, LONG_MAX, &errstr);
181 		if (errstr != NULL)
182 			return got_error(GOT_ERR_BAD_OBJ_HDR);
183 		break;
184 	}
185 
186 	if (type == 0)
187 		return got_error(GOT_ERR_BAD_OBJ_HDR);
188 
189 	*obj = calloc(1, sizeof(**obj));
190 	if (*obj == NULL)
191 		return got_error_from_errno("calloc");
192 	(*obj)->type = type;
193 	(*obj)->hdrlen = hdrlen;
194 	(*obj)->size = size;
195 	return NULL;
196 }
197 
198 const struct got_error *
199 got_object_read_header(struct got_object **obj, int fd)
200 {
201 	const struct got_error *err;
202 	struct got_inflate_buf zb;
203 	char *buf;
204 	const size_t zbsize = 64;
205 	size_t outlen, totlen;
206 	int nbuf = 1;
207 
208 	*obj = NULL;
209 
210 	buf = malloc(zbsize);
211 	if (buf == NULL)
212 		return got_error_from_errno("malloc");
213 
214 	err = got_inflate_init(&zb, buf, zbsize);
215 	if (err)
216 		return err;
217 
218 	totlen = 0;
219 	do {
220 		err = got_inflate_read_fd(&zb, fd, &outlen);
221 		if (err)
222 			goto done;
223 		if (outlen == 0)
224 			break;
225 		totlen += outlen;
226 		if (memchr(zb.outbuf, '\0', outlen) == NULL) {
227 			char *newbuf;
228 			nbuf++;
229 			newbuf = recallocarray(buf, nbuf - 1, nbuf, zbsize);
230 			if (newbuf == NULL) {
231 				err = got_error_from_errno("recallocarray");
232 				goto done;
233 			}
234 			buf = newbuf;
235 			zb.outbuf = newbuf + totlen;
236 			zb.outlen = (nbuf * zbsize) - totlen;
237 		}
238 	} while (memchr(zb.outbuf, '\0', outlen) == NULL);
239 
240 	err = got_object_parse_header(obj, buf, totlen);
241 done:
242 	free(buf);
243 	got_inflate_end(&zb);
244 	return err;
245 }
246 
247 struct got_commit_object *
248 got_object_commit_alloc_partial(void)
249 {
250 	struct got_commit_object *commit;
251 
252 	commit = calloc(1, sizeof(*commit));
253 	if (commit == NULL)
254 		return NULL;
255 	commit->tree_id = malloc(sizeof(*commit->tree_id));
256 	if (commit->tree_id == NULL) {
257 		free(commit);
258 		return NULL;
259 	}
260 
261 	SIMPLEQ_INIT(&commit->parent_ids);
262 
263 	return commit;
264 }
265 
266 const struct got_error *
267 got_object_commit_add_parent(struct got_commit_object *commit,
268     const char *id_str)
269 {
270 	const struct got_error *err = NULL;
271 	struct got_object_qid *qid;
272 
273 	err = got_object_qid_alloc_partial(&qid);
274 	if (err)
275 		return err;
276 
277 	if (!got_parse_sha1_digest(qid->id->sha1, id_str)) {
278 		err = got_error(GOT_ERR_BAD_OBJ_DATA);
279 		got_object_qid_free(qid);
280 		return err;
281 	}
282 
283 	SIMPLEQ_INSERT_TAIL(&commit->parent_ids, qid, entry);
284 	commit->nparents++;
285 
286 	return NULL;
287 }
288 
289 static const struct got_error *
290 parse_gmtoff(time_t *gmtoff, const char *tzstr)
291 {
292 	int sign = 1;
293 	const char *p = tzstr;
294 	time_t h, m;
295 
296 	*gmtoff = 0;
297 
298 	if (*p == '-')
299 		sign = -1;
300 	else if (*p != '+')
301 		return got_error(GOT_ERR_BAD_OBJ_DATA);
302 	p++;
303 	if (!isdigit(*p) && !isdigit(*(p + 1)))
304 		return got_error(GOT_ERR_BAD_OBJ_DATA);
305 	h = (((*p - '0') * 10) + (*(p + 1) - '0'));
306 
307 	p += 2;
308 	if (!isdigit(*p) && !isdigit(*(p + 1)))
309 		return got_error(GOT_ERR_BAD_OBJ_DATA);
310 	m = ((*p - '0') * 10) + (*(p + 1) - '0');
311 
312 	*gmtoff = (h * 60 * 60 + m * 60) * sign;
313 	return NULL;
314 }
315 
316 static const struct got_error *
317 parse_commit_time(time_t *time, time_t *gmtoff, char *committer)
318 {
319 	const struct got_error *err = NULL;
320 	const char *errstr;
321 	char *space, *tzstr;
322 
323 	/* Parse and strip off trailing timezone indicator string. */
324 	space = strrchr(committer, ' ');
325 	if (space == NULL)
326 		return got_error(GOT_ERR_BAD_OBJ_DATA);
327 	tzstr = strdup(space + 1);
328 	if (tzstr == NULL)
329 		return got_error_from_errno("strdup");
330 	err = parse_gmtoff(gmtoff, tzstr);
331 	free(tzstr);
332 	if (err)
333 		return err;
334 	*space = '\0';
335 
336 	/* Timestamp is separated from committer name + email by space. */
337 	space = strrchr(committer, ' ');
338 	if (space == NULL)
339 		return got_error(GOT_ERR_BAD_OBJ_DATA);
340 
341 	/* Timestamp parsed here is expressed as UNIX timestamp (UTC). */
342 	*time = strtonum(space + 1, 0, INT64_MAX, &errstr);
343 	if (errstr)
344 		return got_error(GOT_ERR_BAD_OBJ_DATA);
345 
346 	/* Strip off parsed time information, leaving just author and email. */
347 	*space = '\0';
348 
349 	return NULL;
350 }
351 
352 void
353 got_object_commit_close(struct got_commit_object *commit)
354 {
355 	if (commit->refcnt > 0) {
356 		commit->refcnt--;
357 		if (commit->refcnt > 0)
358 			return;
359 	}
360 
361 	got_object_id_queue_free(&commit->parent_ids);
362 	free(commit->tree_id);
363 	free(commit->author);
364 	free(commit->committer);
365 	free(commit->logmsg);
366 	free(commit);
367 }
368 
369 struct got_object_id *
370 got_object_commit_get_tree_id(struct got_commit_object *commit)
371 {
372 	return commit->tree_id;
373 }
374 
375 int
376 got_object_commit_get_nparents(struct got_commit_object *commit)
377 {
378 	return commit->nparents;
379 }
380 
381 const struct got_object_id_queue *
382 got_object_commit_get_parent_ids(struct got_commit_object *commit)
383 {
384 	return &commit->parent_ids;
385 }
386 
387 const char *
388 got_object_commit_get_author(struct got_commit_object *commit)
389 {
390 	return commit->author;
391 }
392 
393 time_t
394 got_object_commit_get_author_time(struct got_commit_object *commit)
395 {
396 	return commit->author_time;
397 }
398 
399 time_t got_object_commit_get_author_gmtoff(struct got_commit_object *commit)
400 {
401 	return commit->author_gmtoff;
402 }
403 
404 const char *
405 got_object_commit_get_committer(struct got_commit_object *commit)
406 {
407 	return commit->committer;
408 }
409 
410 time_t
411 got_object_commit_get_committer_time(struct got_commit_object *commit)
412 {
413 	return commit->committer_time;
414 }
415 
416 time_t
417 got_object_commit_get_committer_gmtoff(struct got_commit_object *commit)
418 {
419 	return commit->committer_gmtoff;
420 }
421 
422 #define GOT_GPG_BEGIN_STR "gpgsig -----BEGIN PGP SIGNATURE-----"
423 #define GOT_GPG_END_STR " -----END PGP SIGNATURE-----"
424 
425 const struct got_error *
426 got_object_commit_get_logmsg(char **logmsg, struct got_commit_object *commit)
427 {
428 	const struct got_error *err = NULL;
429 	int gpgsig = 0;
430 	char *msg0, *msg, *line, *s;
431 	size_t len;
432 
433 	*logmsg = NULL;
434 
435 	msg0 = strdup(commit->logmsg);
436 	if (msg0 == NULL)
437 		return got_error_from_errno("strdup");
438 
439 	/* Copy log message line by line to strip out GPG sigs... */
440 	msg = msg0;
441 	do {
442 		line = strsep(&msg, "\n");
443 
444 		if (line) {
445 			/* Skip over GPG signatures. */
446 			if (gpgsig) {
447 				if (strcmp(line, GOT_GPG_END_STR) == 0) {
448 					gpgsig = 0;
449 					/* Skip empty line after sig. */
450 					line = strsep(&msg, "\n");
451 				}
452 				continue;
453 			} else if (strcmp(line, GOT_GPG_BEGIN_STR) == 0) {
454 				gpgsig = 1;
455 				continue;
456 			}
457 			if (asprintf(&s, "%s%s\n",
458 			    *logmsg ? *logmsg : "", line) == -1) {
459 				err = got_error_from_errno("asprintf");
460 				goto done;
461 			}
462 			free(*logmsg);
463 			*logmsg = s;
464 		}
465 	} while (line);
466 
467 	/* Trim redundant trailing whitespace. */
468 	len = strlen(*logmsg);
469 	while (len > 1 && isspace((unsigned char)(*logmsg)[len - 2]) &&
470 	    isspace((unsigned char)(*logmsg)[len - 1])) {
471 		(*logmsg)[len - 1] = '\0';
472 		len--;
473 	}
474 done:
475 	free(msg0);
476 	if (err) {
477 		free(*logmsg);
478 		*logmsg = NULL;
479 	}
480 	return err;
481 }
482 
483 const struct got_error *
484 got_object_parse_commit(struct got_commit_object **commit, char *buf,
485     size_t len)
486 {
487 	const struct got_error *err = NULL;
488 	char *s = buf;
489 	size_t label_len;
490 	ssize_t remain = (ssize_t)len;
491 
492 	*commit = got_object_commit_alloc_partial();
493 	if (*commit == NULL)
494 		return got_error_from_errno("got_object_commit_alloc_partial");
495 
496 	label_len = strlen(GOT_COMMIT_LABEL_TREE);
497 	if (strncmp(s, GOT_COMMIT_LABEL_TREE, label_len) == 0) {
498 		remain -= label_len;
499 		if (remain < SHA1_DIGEST_STRING_LENGTH) {
500 			err = got_error(GOT_ERR_BAD_OBJ_DATA);
501 			goto done;
502 		}
503 		s += label_len;
504 		if (!got_parse_sha1_digest((*commit)->tree_id->sha1, s)) {
505 			err = got_error(GOT_ERR_BAD_OBJ_DATA);
506 			goto done;
507 		}
508 		remain -= SHA1_DIGEST_STRING_LENGTH;
509 		s += SHA1_DIGEST_STRING_LENGTH;
510 	} else {
511 		err = got_error(GOT_ERR_BAD_OBJ_DATA);
512 		goto done;
513 	}
514 
515 	label_len = strlen(GOT_COMMIT_LABEL_PARENT);
516 	while (strncmp(s, GOT_COMMIT_LABEL_PARENT, label_len) == 0) {
517 		remain -= label_len;
518 		if (remain < SHA1_DIGEST_STRING_LENGTH) {
519 			err = got_error(GOT_ERR_BAD_OBJ_DATA);
520 			goto done;
521 		}
522 		s += label_len;
523 		err = got_object_commit_add_parent(*commit, s);
524 		if (err)
525 			goto done;
526 
527 		remain -= SHA1_DIGEST_STRING_LENGTH;
528 		s += SHA1_DIGEST_STRING_LENGTH;
529 	}
530 
531 	label_len = strlen(GOT_COMMIT_LABEL_AUTHOR);
532 	if (strncmp(s, GOT_COMMIT_LABEL_AUTHOR, label_len) == 0) {
533 		char *p;
534 		size_t slen;
535 
536 		remain -= label_len;
537 		if (remain <= 0) {
538 			err = got_error(GOT_ERR_BAD_OBJ_DATA);
539 			goto done;
540 		}
541 		s += label_len;
542 		p = memchr(s, '\n', remain);
543 		if (p == NULL) {
544 			err = got_error(GOT_ERR_BAD_OBJ_DATA);
545 			goto done;
546 		}
547 		*p = '\0';
548 		slen = strlen(s);
549 		err = parse_commit_time(&(*commit)->author_time,
550 		    &(*commit)->author_gmtoff, s);
551 		if (err)
552 			goto done;
553 		(*commit)->author = strdup(s);
554 		if ((*commit)->author == NULL) {
555 			err = got_error_from_errno("strdup");
556 			goto done;
557 		}
558 		s += slen + 1;
559 		remain -= slen + 1;
560 	}
561 
562 	label_len = strlen(GOT_COMMIT_LABEL_COMMITTER);
563 	if (strncmp(s, GOT_COMMIT_LABEL_COMMITTER, label_len) == 0) {
564 		char *p;
565 		size_t slen;
566 
567 		remain -= label_len;
568 		if (remain <= 0) {
569 			err = got_error(GOT_ERR_BAD_OBJ_DATA);
570 			goto done;
571 		}
572 		s += label_len;
573 		p = memchr(s, '\n', remain);
574 		if (p == NULL) {
575 			err = got_error(GOT_ERR_BAD_OBJ_DATA);
576 			goto done;
577 		}
578 		*p = '\0';
579 		slen = strlen(s);
580 		err = parse_commit_time(&(*commit)->committer_time,
581 		    &(*commit)->committer_gmtoff, s);
582 		if (err)
583 			goto done;
584 		(*commit)->committer = strdup(s);
585 		if ((*commit)->committer == NULL) {
586 			err = got_error_from_errno("strdup");
587 			goto done;
588 		}
589 		s += slen + 1;
590 		remain -= slen + 1;
591 	}
592 
593 	(*commit)->logmsg = strndup(s, remain);
594 	if ((*commit)->logmsg == NULL) {
595 		err = got_error_from_errno("strndup");
596 		goto done;
597 	}
598 done:
599 	if (err) {
600 		got_object_commit_close(*commit);
601 		*commit = NULL;
602 	}
603 	return err;
604 }
605 
606 void
607 got_object_tree_entry_close(struct got_tree_entry *te)
608 {
609 	free(te->id);
610 	free(te->name);
611 	free(te);
612 }
613 
614 void
615 got_object_tree_entries_close(struct got_tree_entries *entries)
616 {
617 	struct got_tree_entry *te;
618 
619 	while (!SIMPLEQ_EMPTY(&entries->head)) {
620 		te = SIMPLEQ_FIRST(&entries->head);
621 		SIMPLEQ_REMOVE_HEAD(&entries->head, entry);
622 		got_object_tree_entry_close(te);
623 	}
624 }
625 
626 void
627 got_object_tree_close(struct got_tree_object *tree)
628 {
629 	if (tree->refcnt > 0) {
630 		tree->refcnt--;
631 		if (tree->refcnt > 0)
632 			return;
633 	}
634 
635 	got_object_tree_entries_close(&tree->entries);
636 	free(tree);
637 }
638 
639 struct got_tree_entry *
640 got_alloc_tree_entry_partial(void)
641 {
642 	struct got_tree_entry *te;
643 
644 	te = malloc(sizeof(*te));
645 	if (te == NULL)
646 		return NULL;
647 
648 	te->id = malloc(sizeof(*te->id));
649 	if (te->id == NULL) {
650 		free(te);
651 		te = NULL;
652 	}
653 	return te;
654 }
655 
656 static const struct got_error *
657 parse_tree_entry(struct got_tree_entry **te, size_t *elen, char *buf,
658     size_t maxlen)
659 {
660 	char *p, *space;
661 	const struct got_error *err = NULL;
662 
663 	*elen = 0;
664 
665 	*te = got_alloc_tree_entry_partial();
666 	if (*te == NULL)
667 		return got_error_from_errno("got_alloc_tree_entry_partial");
668 
669 	*elen = strnlen(buf, maxlen) + 1;
670 	if (*elen > maxlen) {
671 		free(*te);
672 		*te = NULL;
673 		return got_error(GOT_ERR_BAD_OBJ_DATA);
674 	}
675 
676 	space = memchr(buf, ' ', *elen);
677 	if (space == NULL || space <= buf) {
678 		err = got_error(GOT_ERR_BAD_OBJ_DATA);
679 		free(*te);
680 		*te = NULL;
681 		return err;
682 	}
683 	(*te)->mode = 0;
684 	p = buf;
685 	while (p < space) {
686 		if (*p < '0' && *p > '7') {
687 			err = got_error(GOT_ERR_BAD_OBJ_DATA);
688 			goto done;
689 		}
690 		(*te)->mode <<= 3;
691 		(*te)->mode |= *p - '0';
692 		p++;
693 	}
694 
695 	(*te)->name = strdup(space + 1);
696 	if (*elen > maxlen || maxlen - *elen < SHA1_DIGEST_LENGTH) {
697 		err = got_error(GOT_ERR_BAD_OBJ_DATA);
698 		goto done;
699 	}
700 	buf += *elen;
701 	memcpy((*te)->id->sha1, buf, SHA1_DIGEST_LENGTH);
702 	*elen += SHA1_DIGEST_LENGTH;
703 done:
704 	if (err) {
705 		got_object_tree_entry_close(*te);
706 		*te = NULL;
707 	}
708 	return err;
709 }
710 
711 const struct got_error *
712 got_object_parse_tree(struct got_tree_object **tree, uint8_t *buf, size_t len)
713 {
714 	const struct got_error *err;
715 	size_t remain = len;
716 	struct got_pathlist_head pathlist;
717 	struct got_pathlist_entry *pe;
718 
719 	TAILQ_INIT(&pathlist);
720 
721 	*tree = calloc(1, sizeof(**tree));
722 	if (*tree == NULL)
723 		return got_error_from_errno("calloc");
724 
725 	SIMPLEQ_INIT(&(*tree)->entries.head);
726 
727 	while (remain > 0) {
728 		struct got_tree_entry *te;
729 		struct got_pathlist_entry *new = NULL;
730 		size_t elen;
731 
732 		err = parse_tree_entry(&te, &elen, buf, remain);
733 		if (err)
734 			goto done;
735 		err = got_pathlist_insert(&new, &pathlist, te->name, te);
736 		if (err)
737 			goto done;
738 		if (new == NULL) {
739 			err = got_error(GOT_ERR_TREE_DUP_ENTRY);
740 			goto done;
741 		}
742 		buf += elen;
743 		remain -= elen;
744 	}
745 
746 	if (remain != 0) {
747 		got_object_tree_close(*tree);
748 		*tree = NULL;
749 		err = got_error(GOT_ERR_BAD_OBJ_DATA);
750 		goto done;
751 	}
752 
753 	TAILQ_FOREACH(pe, &pathlist, entry) {
754 		struct got_tree_entry *te = pe->data;
755 		(*tree)->entries.nentries++;
756 		SIMPLEQ_INSERT_TAIL(&(*tree)->entries.head, te, entry);
757 	}
758 done:
759 	got_pathlist_free(&pathlist);
760 	return err;
761 }
762 
763 void
764 got_object_tag_close(struct got_tag_object *tag)
765 {
766 	if (tag->refcnt > 0) {
767 		tag->refcnt--;
768 		if (tag->refcnt > 0)
769 			return;
770 	}
771 
772 	free(tag->tag);
773 	free(tag->tagger);
774 	free(tag->tagmsg);
775 	free(tag);
776 }
777 
778 const struct got_error *
779 got_object_parse_tag(struct got_tag_object **tag, uint8_t *buf, size_t len)
780 {
781 	const struct got_error *err = NULL;
782 	size_t remain = len;
783 	char *s = buf;
784 	size_t label_len;
785 
786 	*tag = calloc(1, sizeof(**tag));
787 	if (*tag == NULL)
788 		return got_error_from_errno("calloc");
789 
790 	label_len = strlen(GOT_TAG_LABEL_OBJECT);
791 	if (strncmp(s, GOT_TAG_LABEL_OBJECT, label_len) == 0) {
792 		remain -= label_len;
793 		if (remain < SHA1_DIGEST_STRING_LENGTH) {
794 			err = got_error(GOT_ERR_BAD_OBJ_DATA);
795 			goto done;
796 		}
797 		s += label_len;
798 		if (!got_parse_sha1_digest((*tag)->id.sha1, s)) {
799 			err = got_error(GOT_ERR_BAD_OBJ_DATA);
800 			goto done;
801 		}
802 		remain -= SHA1_DIGEST_STRING_LENGTH;
803 		s += SHA1_DIGEST_STRING_LENGTH;
804 	} else {
805 		err = got_error(GOT_ERR_BAD_OBJ_DATA);
806 		goto done;
807 	}
808 
809 	if (remain <= 0) {
810 		err = got_error(GOT_ERR_BAD_OBJ_DATA);
811 		goto done;
812 	}
813 
814 	label_len = strlen(GOT_TAG_LABEL_TYPE);
815 	if (strncmp(s, GOT_TAG_LABEL_TYPE, label_len) == 0) {
816 		remain -= label_len;
817 		if (remain <= 0) {
818 			err = got_error(GOT_ERR_BAD_OBJ_DATA);
819 			goto done;
820 		}
821 		s += label_len;
822 		if (strncmp(s, GOT_OBJ_LABEL_COMMIT,
823 		    strlen(GOT_OBJ_LABEL_COMMIT)) == 0) {
824 			(*tag)->obj_type = GOT_OBJ_TYPE_COMMIT;
825 			label_len = strlen(GOT_OBJ_LABEL_COMMIT);
826 			s += label_len;
827 			remain -= label_len;
828 		} else if (strncmp(s, GOT_OBJ_LABEL_TREE,
829 		    strlen(GOT_OBJ_LABEL_TREE)) == 0) {
830 			(*tag)->obj_type = GOT_OBJ_TYPE_TREE;
831 			label_len = strlen(GOT_OBJ_LABEL_TREE);
832 			s += label_len;
833 			remain -= label_len;
834 		} else if (strncmp(s, GOT_OBJ_LABEL_BLOB,
835 		    strlen(GOT_OBJ_LABEL_BLOB)) == 0) {
836 			(*tag)->obj_type = GOT_OBJ_TYPE_BLOB;
837 			label_len = strlen(GOT_OBJ_LABEL_BLOB);
838 			s += label_len;
839 			remain -= label_len;
840 		} else if (strncmp(s, GOT_OBJ_LABEL_TAG,
841 		    strlen(GOT_OBJ_LABEL_TAG)) == 0) {
842 			(*tag)->obj_type = GOT_OBJ_TYPE_TAG;
843 			label_len = strlen(GOT_OBJ_LABEL_TAG);
844 			s += label_len;
845 			remain -= label_len;
846 		} else {
847 			err = got_error(GOT_ERR_BAD_OBJ_DATA);
848 			goto done;
849 		}
850 
851 		if (remain <= 0 || *s != '\n') {
852 			err = got_error(GOT_ERR_BAD_OBJ_DATA);
853 			goto done;
854 		}
855 		s++;
856 		remain--;
857 		if (remain <= 0) {
858 			err = got_error(GOT_ERR_BAD_OBJ_DATA);
859 			goto done;
860 		}
861 	} else {
862 		err = got_error(GOT_ERR_BAD_OBJ_DATA);
863 		goto done;
864 	}
865 
866 	label_len = strlen(GOT_TAG_LABEL_TAG);
867 	if (strncmp(s, GOT_TAG_LABEL_TAG, label_len) == 0) {
868 		char *p;
869 		size_t slen;
870 		remain -= label_len;
871 		if (remain <= 0) {
872 			err = got_error(GOT_ERR_BAD_OBJ_DATA);
873 			goto done;
874 		}
875 		s += label_len;
876 		p = memchr(s, '\n', remain);
877 		if (p == NULL) {
878 			err = got_error(GOT_ERR_BAD_OBJ_DATA);
879 			goto done;
880 		}
881 		*p = '\0';
882 		slen = strlen(s);
883 		(*tag)->tag = strndup(s, slen);
884 		if ((*tag)->tag == NULL) {
885 			err = got_error_from_errno("strndup");
886 			goto done;
887 		}
888 		s += slen + 1;
889 		remain -= slen + 1;
890 		if (remain <= 0) {
891 			err = got_error(GOT_ERR_BAD_OBJ_DATA);
892 			goto done;
893 		}
894 	} else {
895 		err = got_error(GOT_ERR_BAD_OBJ_DATA);
896 		goto done;
897 	}
898 
899 	label_len = strlen(GOT_TAG_LABEL_TAGGER);
900 	if (strncmp(s, GOT_TAG_LABEL_TAGGER, label_len) == 0) {
901 		char *p;
902 		size_t slen;
903 
904 		remain -= label_len;
905 		if (remain <= 0) {
906 			err = got_error(GOT_ERR_BAD_OBJ_DATA);
907 			goto done;
908 		}
909 		s += label_len;
910 		p = memchr(s, '\n', remain);
911 		if (p == NULL) {
912 			err = got_error(GOT_ERR_BAD_OBJ_DATA);
913 			goto done;
914 		}
915 		*p = '\0';
916 		slen = strlen(s);
917 		err = parse_commit_time(&(*tag)->tagger_time,
918 		    &(*tag)->tagger_gmtoff, s);
919 		if (err)
920 			goto done;
921 		(*tag)->tagger = strdup(s);
922 		if ((*tag)->tagger == NULL) {
923 			err = got_error_from_errno("strdup");
924 			goto done;
925 		}
926 		s += slen + 1;
927 		remain -= slen + 1;
928 		if (remain <= 0) {
929 			err = got_error(GOT_ERR_BAD_OBJ_DATA);
930 			goto done;
931 		}
932 	} else {
933 		/* Some old tags in the Linux git repo have no tagger. */
934 		(*tag)->tagger = strdup("");
935 		if ((*tag)->tagger == NULL) {
936 			err = got_error_from_errno("strdup");
937 			goto done;
938 		}
939 	}
940 
941 	(*tag)->tagmsg = strndup(s, remain);
942 	if ((*tag)->tagmsg == NULL) {
943 		err = got_error_from_errno("strndup");
944 		goto done;
945 	}
946 done:
947 	if (err) {
948 		got_object_tag_close(*tag);
949 		*tag = NULL;
950 	}
951 	return err;
952 }
953 
954 const struct got_error *
955 got_read_file_to_mem(uint8_t **outbuf, size_t *outlen, FILE *f)
956 {
957 	const struct got_error *err = NULL;
958 	static const size_t blocksize = 512;
959 	size_t n, total, remain;
960 	uint8_t *buf;
961 
962 	*outbuf = NULL;
963 	*outlen = 0;
964 
965 	buf = malloc(blocksize);
966 	if (buf == NULL)
967 		return got_error_from_errno("malloc");
968 
969 	remain = blocksize;
970 	total = 0;
971 	for (;;) {
972 		if (remain == 0) {
973 			uint8_t *newbuf;
974 			newbuf = reallocarray(buf, 1, total + blocksize);
975 			if (newbuf == NULL) {
976 				err = got_error_from_errno("reallocarray");
977 				goto done;
978 			}
979 			buf = newbuf;
980 			remain += blocksize;
981 		}
982 		n = fread(buf + total, 1, remain, f);
983 		if (n == 0) {
984 			if (ferror(f)) {
985 				err = got_ferror(f, GOT_ERR_IO);
986 				goto done;
987 			}
988 			break; /* EOF */
989 		}
990 		remain -= n;
991 		total += n;
992 	};
993 
994 done:
995 	if (err == NULL) {
996 		*outbuf = buf;
997 		*outlen = total;
998 	} else
999 		free(buf);
1000 	return err;
1001 }