Commit Briefs
sync usage with reality
The -h and -V/--version flags must be given before the command; with those flags the command is actually optional, but don't over-complicate the usage string with these nitpicks. ok/improvements stsp@
backout Make & command in tog's log view display "searching..."
The limit feature is more than just a search operation, tog's man page has been updated accordingly.
Make & command in tog's log view display "searching..." while loading commits.
This command acts like a search operation, and the display should reflect that.
tog: open help in fullscreen irrespective of view configuration
Prompted by a suggestion from stsp to make the help view distinct rather than follow the default behaviour of established views. Occupying the fullscreen seems to be a somewhat established convention for TUI apps. ok stsp@
drop unconventional got_object_commit_dup() routine
Replace with got_object_commit_retain() to increment commit object reference counter. suggested by and ok stsp@
tog: don't embed utf8 glyphs into tog.c source code
Reported by stsp: Embedded utf8 precludes developers running C locales from browsing the code. Fix was suggested by stsp with hints from the tmux(1) codebase. ok stsp@
tog: refactor search setup into tog_view function pointers
Suggested by stsp. While here, add declarations for new help view routines. ok stsp@
tog: implement runtime help accessible via H,F1 keymaps
Original idea inspired from discussion with tb, tobhe, and stsp at g2k22: display view-specific help, with option to toggle display of full key map reference when {H,F1} is pressed again inside the help view. Includes improvements suggested by stsp. ok stsp@