Commit Briefs
CHANGES for 0.94 (tags/0.94)
adjust expected output to make 2 failing gotd regression tests pass
The repo_write process still announces HEAD twice, once with its symref target and once with the resolved symref object hash. I cannot recall if this is deliberate but let's accept it for now to avoid test failures being flagged due to this issue, which is mostly cosmetic.
detect concurrent changes to the set of pack files while matching object IDs
This should prevent a use-after-free crash I observed in gotwebd. ok op@
gotwebd: fix broken signal catching due to a pasto
While here, remove completely the libevent handling of SIGPIPE in favour of the already existing signal(3) call to ignore it; there's no point in logging a SIGPIPE.
fix memory leak on error in got_privsep_recv_painted_commits()
Diff from Kyle Ackerman, thank you! I've added a imsg_free() call before the break too.
gotwebd: inline and remove IMSG_SIZE_CHECK()
I always find confusing if IMSG_SIZE_CHECK() takes pointers or not, and we had at least a few instances of wrong usages, so inline (with exact size checks) and remove the macro. ok stsp@
remove the gotwebd repository cache
It only had 4 slots so was never quite useful, and sharing of sock->pack_fds across cached repositories seems problematic. with help from + ok op@
gotwebd: send a UNIQUE temp fd
main_compose_sockets() has the 'feature' of implicitly dup(2)'ing the passed file descriptior. But it's not what we need for the temp fds, since those needs to be unique per-children. debugged with stsp@
gotwebd: don't chdir to / before spawning the child processes
allows to run gotwebd from the got checkout again.