set gitconfig_remotes to NULL to avoid a double-free, and reset the global author name/email fields too. ok stsp@

ok op@

got_repo_pack_fds_close will try to close all of the GOT_PACK_NUM_TEMPFILES fds, even the ones that didn't manage to get a value from got_opentempfd(), which would result in a close(0) if we do not initialize to -1 here.

Found by llvm's scan-build (bad free). OK stsp

Found by llvm's scan-build (dead store). OK stsp

ok op, tracey

thanks for all the help massaging this diff

Avoids clobbering open files for delta base/accumulation, leaking file descriptors, and triggering errors from close(2) during got_repo_close() as we try to close the same file descriptor more than once.

found by tracey

This prepares for callers of got_repo_open() that cannot afford to open files in /tmp, such as gotwebd. In a follow-up change, we could ask such callers to pass in the required amount of open temporary files. One consequence is that got_repo_open() now requires the "cpath" pledge promise. Add the "cpath" promise to affected callers and remove it once the repository has been opened. ok tracey

Saves us from doing a malloc/free call for every item on the list. ok op@