Commit Briefs

Stefan Sperling

gotwebd: initialize IPv4 and IPv6 sockets in the same way

ok tracey


Stefan Sperling

gotwebd: don't listen on FCGI sockets when FCGI is not enabled

ok tracey


Stefan Sperling

gotwebd: do not allocate server/socket list heads separately

ok millert@


Stefan Sperling

gotwebd: do not allocate address list heads separately, this is unnecessary

ok millert@


Omar Polo

fix snprintf error handling

follow the "proper secure idiom" described in the CAVEATS section of printf(3). reminded by tb@ and millert@


Omar Polo

convert two snprintf to strlcpy

"looks good to me" millert@


Omar Polo

check for fprintf failure


Stefan Sperling

got(1): Replace 'Ar sign' with 'Cm sign'

Cm sign matches the markup used in the ssh-keygen(1) man page. Patch by Josiah Frentsos



Stefan Sperling

Group options in accordance with style(9)

patch by Josiah Frentsos


Omar Polo

gotwebd: fix double free in gotweb_process_request

don't free the querystring, it's already done later by fcgi_celanup_request. ok tracey@


Stefan Sperling

tog: add missing checks for NULL pointers in log view state

ok jamsek


Mark Jamsek

tog: don't block when processing log view 'G' key map

As per stsp's TODO item, make tog respond to key presses while "loading..." history. Initial testing in src.git appears to work as intended. ok stsp@


Mark Jamsek

tog: fix delayed tree index update

If a child blame view has been opened, halfdelay() is reset to a 1 second refresh rate, so the index in the header lags behind subtree navigation as we set the index based on the selected tree entry, which isn't updated till that refresh cycle completes. Don't wait for the selected_entry to update; instead, compute the index from the first displayed entry and the currently selected line index. improved by and ok stsp@


Mark Jamsek

tog: move all 'G' logic into log_move_cursor_down()

Previously, we only handled 'G' in log_move_cursor_down() when all commits had not yet been loaded; move the case where all commits are already loaded into this routine too, and simplify by handling both cases the same. This change was prompted by Mikhail's observation of a redundant assignment in the previous 'G' handling in log_move_cursor_down(). ok stsp@