pack_fds_tmp is not always free'd. However, while here, simplify it to not use a temporary array. ok stsp@

in the loop of match_loose_object we allocate a string per directory entry that in some case it was free(3)'d before `continue' or `goto', but not always. Instead, use a more common idiom. ok stsp@

ok op@

set gitconfig_remotes to NULL to avoid a double-free, and reset the global author name/email fields too. ok stsp@

ok op@

got_repo_pack_fds_close will try to close all of the GOT_PACK_NUM_TEMPFILES fds, even the ones that didn't manage to get a value from got_opentempfd(), which would result in a close(0) if we do not initialize to -1 here.

Found by llvm's scan-build (bad free). OK stsp

Found by llvm's scan-build (dead store). OK stsp

ok op, tracey

thanks for all the help massaging this diff