Commit Briefs

Omar Polo

gitconfig.c: look for comments after trimming the start of the line

This fixes the (harmless) errors raised by gitconfig.c on indented comment lines and adds a test case for it. Reported by James Cook, thanks! ok stsp@



Omar Polo

gitconfig.c: fix read/write out of bounds

conf_parse_line advances the `line' pointer without decrementing the line size `sz'. This makes the parsing code mistakingly reading from the next line (`line' is just a pointer in a bigger buffer that holds the whole file) and may mangle it by writing NUL bytes in it. Add also a new regress case to trigger this case. Reported by falsifian on IRC, thanks! ok stsp@


Omar Polo

gitconfig.c: fix printing of debugging logs

all the othe LOG_DBG calls assume \n is implicit (like with err(3)), so remove the only explicit \n and make log_debug printing a newline too.



Omar Polo

convert two files to utf8

ok stsp


Omar Polo

replace malloc+memcpy with strndup. no functional change intended

ok stsp@






Stefan Sperling

parse remotes from gitconfig