Commit Briefs
build with -Wwrite-strings
Throwing this into the mix for a while, we can always get rid of it again if it becomes annoying. No objections from stsp@
build with -Wmissing-prototypes
ok stsp@
let got-read-pack be explicit about whether it could enumerate all objects
This allows the main process to avoid looping over all object IDs again in case the pack file used for enumeration is complete. ok op@
Bring back object enumeration inside got-read-pack as a fast path.
The problem that was found in the earlier version has been fixed. ok op@
revert object enumeration in got-read-pack for now; needs more work
This implementation marked commits and trees as enumerated before all trees which they depend on were enumerated. This behaviour leads to incomplete pack files when a tree is only partially packed and got-read-pack hits a missing tree entry as a result. The algorithm must be reworked such that packed leave nodes are marked enumerated first, then bubble-up. Found by op@
free id and path in load_packed_tree_ids() on error, else they would leak
pointed out by op@
fix a bug in findwixt() which caused pack files with missing parent commits
The 'nskip' variable is supposed to reflect commits which are waiting on the queue and have the 'skip' color. Only increment 'nskip' when adding such commits to the queue. Problem observed with got send -T and a tag pointing to a deleted branch. Test to reproduce the bug written by op@.
use random seeds for murmurhash2
change the three hardcoded seeds to fresh ones generated on demand via arc4random. Suggested/fixed by and ok stsp@
shrink struct got_pack_meta a bit by removing the have_reused_delta flag
This flag can be expressed as m->reused_delta_offset != 0 because all deltas in valid pack files will be written at a non-zero offset. We allocate a huge number of these structs during packing, so every little bit helps.