Commit Briefs

Stefan Sperling

do not hint at empty temporary diff files in the log message buffer

ok op@



Stefan Sperling

use a global flag instead of a per-file flag to detect staged changes

ok op@


Stefan Sperling

use mkstemps(3) instead of mkstemp(3) for opening named temporary files

Allows 'got commit' to use a ".diff" suffix for temporary diff files. ok op@


Stefan Sperling

provide a diff of changes in a temp file while editing a commit log message

ok landry@


Omar Polo

respect umask when creating or changing files and directories

This behaviour is already documented in got-worktree(5) but wasn't actually implemented. ok stsp@


Stefan Sperling

check for unlink(2) errors with the == -1 idiom, rather than != 0

ok op@




Stefan Sperling

do not require local author info during 'got rebase'

My commit to reset committer info during rebase was too strict in some use cases. Even when simply forwarding a branch the rebase operation could now fail if GOT_AUTHOR is not set. To fix this, fall back on existing commiter information if no author is configured. And try to obtain author info from Git config in case GOT_AUTHOR is not set. Problems reported by Mikhail.


Stefan Sperling

reset committer during rebase and histedit

ok op@



Florian Obser

path_got is unused and never assigned, no need to free it

OK stsp


Florian Obser

Do not ignore I/O errors.

Found by llvm's scan-build (dead store). OK stsp


Stefan Sperling

switch 'tog diff' and 'tog blame' to Myers diff for speed

Make the choice of diff algorithm configurable by diff API users. The got and gotweb programs keep using Patience diffs which are prettier than Myers. But tog should be as fast as possible since it is being used interactively. If performance of Patience diff gets improved later we can consider switching tog back over to it. ok tracey jamsek