Commit Briefs
PF_UNIX is not a valid protocol for socketpair
OpenBSD accept it, but FreeBSD disallows it. PF_UNSPEC (or 0) should be used instead. The FastCGI bit in the regress suite still doesn't work on FreeBSD, but at least now it starts.
don't leak a file descriptor
make sure we always close every fd in every possible code path; while there, also add a log_err if fork(2) failed.
initialize the logger early
Initialize the logger as soon as possible and log by default to stderr. With this, some (common?) errors are printed early instead of ending up in syslog. # NB: this is in configless mode % ./gmid -p 80 [2021-07-07 11:05:57] bind: Address already in use % ./gmid -p 81 [2021-07-07 11:13:53] bind: Permission denied %
add --enable-sandbox
patch from Anna "CyberTailor" It's handy for helpers like ebuild's use_enable. (the sandbox is still always enabled by default)
check libimsg too
patch from Anna "CyberTailor"
always append LDFLAGS and CFLAGS
Initial patch from Anna "CyberTailor", tweaked by me (drop guessing_* and always append CFLAGS)
try to preserve as much as possible CFLAGS and LDFLAGS from env
but still try to autodetect with pkg-config if they aren't provided. Passing CFLAGS/LDFLAGS from the command line will still override the guessed ones.