Commit Briefs

Omar Polo

revert commit 346f28eeaa205d268d1e63c7ffd86cf041f6d1e6

keep mark_nonblock in utils.c, as otherwise the build for the regress suite will fail (mark_nonblock needs fatal which is in gmid.c, and we can't link gmid.o with the regress suite...)


Omar Polo

move mark_nonblock to utils.c


Omar Polo

mark various functions as static

By marking all those function as static, the compiler is free to do more optimizations. In addition, those functions are not used outside server.c


Omar Polo

cgi now follows globbing rules



Omar Polo

simplify handle_cgi

Now that I got rid of the enum+switch, adding more state is easier. Before, we used an hack to remember if we had read the CGI reply or not (c->code = -1). This introduces a new state, handle_cgi_reply that reads the CGI script reply, logs it, and only then switches to handle_cgi. handle_cgi itself is cleaner, now it only reads into c->sbuf and send what it had red. We even get, almost for free, the 42 error. If read exists with -1 or 0 from in handle_cgi_reply, we return a proper error to the client. We can extend this further in the future and also try to validate the CGI reply (for now we're only looking for a \n).


Omar Polo

switch to handle_open_conn right after handshake

So we don't re-enter the handle_handsahke and re-do the loop on fnmatch etc. This way, once we're successfully past the handshake, we'll re-enter no handle_open_conn.




Omar Polo

typo


Omar Polo

invert the location precedence: first match wins

It's how httpd(8) does it, and it allows us to call fnmatch less time



Omar Polo

puny_decode: set an error string


Omar Polo

don't log the SNI & matching

I'll re-enable this when i'll improve the logging