Commit Briefs

David du Colombier

upas: fix warnings

smtp.c:232: warning: comparison with string literal results in unspecified behavior smtp.c:244: warning: comparison with string literal results in unspecified behavior marshal.c:1179: warning: variable ‘err’ set but not used LGTM=rsc R=rsc https://codereview.appspot.com/93290043


David du Colombier

libndb: add AUTOLIB(resolv)

LGTM=rsc R=rsc https://codereview.appspot.com/97370043


Russ Cox

acme: fix two flush bugs in new log file

TBR=rsc https://codereview.appspot.com/95010048


Russ Cox

acme: add log file in acme root directory

Reading /mnt/acme/log reports a log of window create, put, and delete events, as they happen. It blocks until the next event is available. Example log output: 8 new /Users/rsc/foo.go 8 put /Users/rsc/foo.go 8 del /Users/rsc/foo.go This lets acme-aware programs react to file writes, for example compiling code, running a test, or updating an import block. TBR=r R=r https://codereview.appspot.com/89560044


Russ Cox

acme: add comment for aligned writes

TBR=r https://codereview.appspot.com/89510044


Russ Cox

acme: use buffered i/o to write file

Bakul Shah has observed corrupted files being written when acme writes over osxfuse to sshfs to a remote file system. In one example we examined, acme is writing an 0xf03-byte file in two system calls, first an 0x806-byte write and then a 0x6fd-byte write. (0x806 is BUFSIZE/sizeof(Rune); this file has no multibyte UTF-8.) What actually ends up happening is that an 0x806-byte file is written: 0x000-0x6fd contains what should be 0x806-0xf03 0x6fd-0x7fa contains zeros 0x7fa-0x806 contains what should be 0x7fa-0x806 (correct!) The theory is that fuse or sshfs or perhaps the remote file server is mishandling the unaligned writes. acme does not seem to be at fault. Using bio here will make the writes align to 8K boundaries, avoiding the bugs in whatever underlying piece is broken. TBR=r https://codereview.appspot.com/89550043


Russ Cox

acme: fix Get of dir in nameless window (thanks Colton Lewis)

TBR=r https://codereview.appspot.com/89390043


Shenghou Ma

dist/main.html: update supported systems and commit log link.

LGTM=rsc R=rsc https://codereview.appspot.com/72340043


Shenghou Ma

man/man1/0intro.1: update supported systems.

LGTM=rsc R=rsc https://codereview.appspot.com/71070050


Russ Cox

acme: copy/cut/paste with ctl+c,x,v

LGTM=rsc R=rsc CC=plan9port.codebot https://codereview.appspot.com/69070045


Russ Cox

acme, sam: handle >1GB files correctly

TBR=rsc https://codereview.appspot.com/74060043


Shenghou Ma

INSTALL: fix architecture detection on Solaris.

And uses gcc for i386 and x86_64. LGTM=rsc R=rsc https://codereview.appspot.com/69860044


David du Colombier

fix gcc 4.8 warnings

LGTM=rsc R=rsc https://codereview.appspot.com/33240044


David du Colombier

fossil: fix p9p changes on view

LGTM=rsc R=rsc https://codereview.appspot.com/31130043


Shenghou Ma

all: DragonFly port.

Fix compilation problems, libdraw still doesn't work right yet. LGTM=rsc R=rsc https://codereview.appspot.com/67820046