Commit Briefs
gotwebd: fix some got_error_from_errno2/3 calls
it's not printf-like so %s don't make sense. Tweak the order of the arguments to obtain the intended output.
gotwebd: avoid needless double fseek()
got_gotweb_closefile() already takes care of rewinding before truncating and closing, so no need to replicate here. ok stsp@
gotwebd: lower log priority of unexpected disconnections
no need to be so loud when a client disconnects earlier than expected, log it only in verbose mode. Don't log GOT_ERR_CANCELLED too since that is only used to communicate the callers that we need to stop. ok stsp@
got_operations.c: use consistently a space before labels
makes diff prettier and easier to read; instead of the label we have the function name in the hunk line.
remove fsync() from got_gotweb_closefile()
discussed with millert@
rename got_gotweb_flushfile -> got_gotweb_closefile
suggested and ok millert@
make got_gotweb_flushfile always close the file
ok millert@
simplify got_gotweb_openfile/flushfile
Return only the FILE *, and require only that to close subsequently. Having to manage the file descriptor too makes using these functions unnecessary complex. millert@ agrees
include sha2.h too where sha1.h is included
In preparation for wide sha256 support; stsp@ agrees. Change done mechanically with find . -iname \*.[cy] -exec sam {} + X ,x/<sha1\.h>/i/\n#include <sha2.h>
gotwebd: abort blame if the client disconnect midway thru
Without setting err when the callback fails we continue the blame machinery.
fix mistaken instances returning NULL instead of err
While here, for consistency, check dup() return value for -1 rather than < 0. ok stsp@
gotwebd: fix briefs/tags navigation overlap
Introduces a separate field for the "next" button (now called "More") and adjusted the CSS/HTML so it's used. Finally, drops the old code used to handle the pagination for the BRIEFS/COMMITS cases. Needs a small hack for the time being, setting the action to TAGS. This is due how qs->action is changed in gotweb.c while handling the request. ok jamsek