Commit Briefs

Dan Cross

Trivial changes: whitespace and modes.

Remote whitespace at the ends of lines. Remove blank lines from the ends of files. Change modes on source files so that they are not executable. Signed-off-by: Dan Cross <cross@gajendra.net>


Gleydson Soares

9term: Add missing parentheses, preventing buffer overflow.

(el-sr) is the string length and (sizeof wdir - strlen(name) - 20) is the buffer size. When the string length is greater than the buffer size, the beginning of the string is supposed to be trimmed to fit in the buffer size. Unfortunately a pair of parentheses were missing, pointing sr outside the buffer, and the for loop below then reads outside the buffer. For certain binary data printed in a window, it causes a segfault. Change-Id: Iffeaa348260ee2a5a36d9577308fb8d1c1688d05 Reviewed-on: https://plan9port-review.googlesource.com/1540 Reviewed-by: Gleydson Soares <gsoares@gmail.com>


Russ Cox

win: local \r cancellation

Change-Id: I4becec052af58c5a52b777004867eb23023b9403 Reviewed-on: https://plan9port-review.googlesource.com/1391 Reviewed-by: Russ Cox <rsc@google.com>


Russ Cox

9term, win: better \r handling (thanks, git)

Change-Id: I75563b911b54d8957d2d004b9c27d0a2f8f043b3 Reviewed-on: https://plan9port-review.googlesource.com/1390 Reviewed-by: Russ Cox <rsc@google.com>


Russ Cox

9term: set TERM=dumb instead of TERM=9term

Everyone seems to assume that TERM != dumb implies ANSI escape codes are okay. In fact, many people assume that unconditionally, but it is easier to argue back about TERM=dumb than TERM=9term. This applies to acme win too, because they share the code. Set termprog=9term or termprog=win for clients who need to know. R=rsc CC=r https://codereview.appspot.com/12532043


Russ Cox

9term: hold mode back door

R=rsc http://codereview.appspot.com/5248056


Russ Cox

win: hide not just passwords but also passphrases

R=rsc, nicolesimons1986 CC=plan9port.codebot http://codereview.appspot.com/4957042


Russ Cox

9term, acme: autoscroll

Ignore scroll/noscroll window setting. Instead, scroll when the write begins in or immediately after the displayed window content. In the new scrolling discipline, executing "Noscroll" is replaced by typing Page Up or using the mouse to scroll higher in the buffer, and executing "Scroll" is replaced by typing End or using the mouse to scroll to the bottom of the buffer. R=r, r2 http://codereview.appspot.com/4433060


Russ Cox

win: another attempt at input modes

R=rsc http://codereview.appspot.com/2476042


Russ Cox

win: add cook/nocook

R=rsc http://codereview.appspot.com/2162042


Russ Cox

9term, win: better echo cancellation

Also just drop \r from output. It's a losing battle to keep turning it off. R=rsc http://codereview.appspot.com/2128042


Russ Cox

win: scroll

R=rsc CC=codebot http://codereview.appspot.com/643041


Russ Cox

win fixes

- don't exit from a "child" note unless rc exited (code copied from 9term.c) - ignore writes to the tag; specifically " Send Noscroll" at startup. R=rsc CC=codebot http://codereview.appspot.com/181115


Russ Cox

win: better SIGPIPE handling


Russ Cox

win: another attempt at DEL