Commit Briefs
re-group the handling of imsgs
while here also do more validation in IMSG_GET_RAW and add a missing NULL check in the return type of req_by_id in the IMSG_CERT_STATUS.
get rid of some ifdefs
just declare the same function in the two branches of #if HAVE_ASR_RUN to avoid further #ifs
work around macos lack of SOCK_CLOEXEC / SOCK_NONBLOCK
rework mark_nonblock so it sets the cloexec flag too and use it in control.c to avoid these flags. (which are expected to become available on a future revision of POSIX and are already widely available.) It's not an issue for telescope to do the socket/accept + fcntl dance because there aren't threads that can fork(2) (there are no threads at all!) reported by @sikmir at github https://github.com/omar-polo/telescope/commit/59ef79dd19611c7846b00427e6f2267c748ae290#r74498414
gemini_parse_reply: return code and don't close connection
clang static analyzer found a possible use after free: if the code is not 2X in gemini_parse_reply we call close_conn. Then, in net_read we set req->done_header, but req may have been free'd! Actually, this is almost impossible to trigger. close_conn never ends up calling free(req) on its first try, because tls_close takes a while and is rescheduled by libevent. (The check req->ctx != NULL in close_conn is always true if it's a gemini request.) Nevertheless, it's clear to move close_conn out of gemini_parse_reply and simply return the response code: it feels wrong that a "parsing function" takes logic decisions.
move util.c declarations in utils.h
it's not spelled `util.h' because otherwise it'd get included instead of /usr/include/util.h
re-create the tls_config for each request
this is just to simplify the future additions of client certificates.
handle empty replies (i.e. no header)
thanks mansfield for breaking your server so I notice this error
send received page in chunks
imsg can't handle buffer "too big" (around INT16_MAX) and solene@ capsule index is ~29K. The 4K chunk size is completely arbitrary.
wrap unfreeze in ifdef
instead of defining macros in compat.h. It's clearer that it's only for libevent2 this way