Commit Briefs
revert "Skip poll(2) if an imsgbuf has a non-empty read buffer"
imsg_read() will call recvmsg() on the file descriptor regardless of the read buffer's state, so we should ensure that data is ready. The read buffer is used by imsg_get(), not imsg_read(). We already call imsg_get() before imsg_read(), and call the latter only if imsg_get() returns zero.
batch up tree entries in imsg instead of sending one imsg per tree entry
This speeds up loading of trees significantly. ok op@
parse tree entries into an array instead of a pathlist
Avoids some extra malloc/free in a performance-critical path. ok op@
rework logic in got_privsep_recv_tree() to avoid an ugly 'goto'
no functional change
run the search for deltas to reuse in got-read-pack
This significantly speeds up the deltification step of packing by avoiding imsg traffic. gotadmin no longer requests individual raw deltas from got-read-pack to check whether it can reuse them. Instead, got-read-pack obtains a list of objects we want to pack, and hands back the list of all deltas in its pack file which can be reused. Messages are now batched such that imsg buffers are filled as much as possible. Another advantage is that deltas we are not going to reuse will no longer be written to the delta cache file, saving disk space. Before this patch, any raw delta candidate was written to the delta cache file by got-read-pack, and the decision whether to reuse the delta happened afterwards in the gotadmin process. Code for reading individual raw deltas is now unused and could be removed at some point. ok op@
store deltas in compressed form while packing, both in memory and cache file
This reduces memory and disk space consumption during packing. with tweaks + memleak on error fix from op@ ok op@
inline struct got_object_id in struct got_object_qid
Saves us from doing a malloc/free call for every item on the list. ok op@
factorize imsg_clear calls after imsg_flush failures
imsg_clear frees and closes resources allocated as part of enqueueing imsgs so it's a no-op after reads. discussed with and ok stsp@
reuse existing deltas when creating pack files
tested by thomas, naddy, and myself