ok jamsek, stsp

The function already carefully avoids wrapping around zero. While here add a sanity check for limit == 0, like what was previously done for got_get_repo_commits().

and while here make sure 0 is rejected. requested by, improvements and ok stsp@

In some cases (e.g. limit=1 for DIFF action) we could end up traversing all the commits instead of fetching just the one requested. Needless to say, this makes the diff page extremely slow. reported by and ok stsp@

it's not printf-like so %s don't make sense. Tweak the order of the arguments to obtain the intended output.

got_gotweb_closefile() already takes care of rewinding before truncating and closing, so no need to replicate here. ok stsp@

no need to be so loud when a client disconnects earlier than expected, log it only in verbose mode. Don't log GOT_ERR_CANCELLED too since that is only used to communicate the callers that we need to stop. ok stsp@

makes diff prettier and easier to read; instead of the label we have the function name in the hunk line.

discussed with millert@

suggested and ok millert@

ok millert@

Return only the FILE *, and require only that to close subsequently. Having to manage the file descriptor too makes using these functions unnecessary complex. millert@ agrees

In preparation for wide sha256 support; stsp@ agrees. Change done mechanically with find . -iname \*.[cy] -exec sam {} + X ,x/<sha1\.h>/i/\n#include <sha2.h>