Commit Briefs

Omar Polo

gotwebd: drop needless NULL check

We can assume that the querystring was initialized when we reach gotweb_render_header. ok tracey@


Omar Polo

gotwebd: percent-encode generated URLs

This adds a new helper function `gotweb_link' that outputs an HTML link with the parameter correctly escaped. ok stsp@


Omar Polo

gotwebd: add missing closing for div tags_content

reported by the W3C validator.


Omar Polo

gotwebd: fix page title

due to an error in the order of the arguments to fcgi_printf that I've introduced last time I touched gotweb_render_header the title is now "/" (or SCRIPT_NAME) and one assets (the safari pinned tab svg) is a funny URL :)


Omar Polo

gotwebd: shrink struct server

keeping GOTWEBD_REPO_CACHESIZE * sizeof(struct cache_repo) inside the struct server makes it too large for imsg on some platforms (linux at least.) Instead, store a pointer and allocate the array when it's received on the child processes. ok stsp@


Omar Polo

gotwebd: percent-decode the received query string

ok stsp@


Omar Polo

gotwebd: free age and reflist in gotweb_render_branches

ok stsp@


Omar Polo

gotwebd: free scandir(3) result in gotweb_render_index

ok stsp@



Omar Polo

gotwebd: fix leak in gotweb_init_querystring in error path

if strdup fails we fail to free the querystring Found by clang' scan-build.


Omar Polo

gotwebd: add missing fcgi_printf return check

dead store found by clang' scan-build.


Omar Polo

gotwebd: fix assets URLs

In 95a4a5a1e8d0952ee0d2523dc31df7170d80e0b3 I forgot to fix the links for the favicons and the web manifest.


Stefan Sperling

fix regression in gotweb_free_repo_tag(): free(...): modified chunk-pointer

problem introduced in commit 625e5896fc9ecf87ccfc92ad2a65cd3be58f73c0


Omar Polo

gotwebd: free all allocated fields of repo_tag

got_get_repo_tags needs some tweaking to how tag_commit is allocated too. ok stsp@


Omar Polo

gotwebd: fix possible leaks when handling errors

all very unlikely. part of a bigger diff that's ok stsp@