Commit Briefs

Stefan Sperling

add gotctl(8); initially supported commands are 'info' and 'stop'

This will be used by an upcoming regress test suite for gotd(8). ok tracey



Stefan Sperling

remove sendfd pledge promise from gotd repo_read process

Have the parent process send one end of the pipe directly to gotsh(1), such that repo_write can run without "sendfd". Combining "sendfd" and "recvfd" in the same process is frowned upon. ok tracey


Stefan Sperling

remove sendfd pledge promise from gotd repo_write process

Have the parent process send one end of the pipe directly to gotsh(1), such that repo_write can run without "sendfd". Combining "sendfd" and "recvfd" in the same process is frowned upon. ok tracey


Omar Polo

change add_delta to take an off_t instead of size_t.

add_delta already calls got_delta_open casting the size_t to off_t, and all the add_delta callers pass an off_t anyway; fixes an implicit off_t truncation. ok stsp@


Stefan Sperling

stop installing git-{receive,upload}-pack symlinks to gotsh in ~/bin

Having those links in the user's PATH can make our send/fetch regression tests fail. We do want to talk to git-daemon during those tests, and these symlinks can get in the way of that.



Stefan Sperling

plug a memory leak on error in got_gotconfig_read()

ok op@





Omar Polo

fix off_t type mismatch in gotd

see e082ed67; ok stsp@


Omar Polo

check size before calling mmap(2)

It's only a preparatory step, as checking whether a size_t is less than SIZE_MAX is moot. In a follow-up commit, however, the `filesize' field of the struct got_pack will become off_t and these checks will kick in. This also makes consistent how we guard mmap(2) against empty files. ok and improvements stsp@


Omar Polo

add bounds check when reading a delta offset from a packed object

ok stsp@