and adjust the callers. discussed with and ok stsp@

got_get_repo_commits iterates over the commits and build a queue for later display. My previous memleak fix moved the TAILQ_INSERT_TAIL *before* the logic to exit the loop and so it broke the pagination. This fixes it by delaying the insertion into the queue, but also by moving the check for the "previous" button after we've opened the commit. ok tracey

This adds a new helper function `gotweb_link' that outputs an HTML link with the parameter correctly escaped. ok stsp@

got_get_repo_commits mixes ids allocated on the heap and the one returned by the iter_next in the same variable, and then even attemp to free it. This is both a leak (we loose the pointer to the previously allocated id) and a possible invalid free since the object id pointer returned by the graph iterator is not to be passed to free(3). part of a bigger diff that's ok stsp@

ok stsp@

ok stsp@

ok stsp@

commit_id is not NULL if got_repo_match_object_id returned successfully. ok stsp@

ok stsp@

ok stsp@

in_repo_path was used only to build a path, it's then assigned to path (which is NULL at that point.) Just asprintf into path. ok stsp@

call got_get_repo_commit only once and avoid leaking the field of repo_commit at each loop iteration. ok stsp@

some code-paths may leak it. ok stsp@