Commit Briefs

Stefan Sperling

use RB_TREE instead of STAILQ to manage packindex bloom filters; much faster

diff | patch | tree

Stefan Sperling

implement 'got diff -c' for diffing commits with optional filtering by path

Need for filtering by path sugggested by kn@ ok naddy@

diff | patch | tree

Stefan Sperling

verify object ID checksums while loose objects are being accessed

diff | patch | tree

Stefan Sperling

make got_packidx_get_packfile_path() usable for callers who only have a path

diff | patch | tree

Stefan Sperling

implement 'gotadmin cleanup'

diff | patch | tree

Christian Weisgerber

switch from SIMPLEQ to equivalent STAILQ macros

The singly-linked tail queue macros were added to OpenBSD 6.9 and are more widely available on other systems. ok stsp

diff | patch | tree

Stefan Sperling

raw object size should not include the length of the object's header

This way, the size of a raw object is the same regardless of whether the object was found in a loose object file or in a pack file.

diff | patch | tree

Stefan Sperling

introduce got_object_id_queue_copy()

This will be required by a future 'gotadmin pack' command.

diff | patch | tree

Stefan Sperling

introduce got_object_open_loose_fd() for library-internal use

diff | patch | tree

Stefan Sperling

add got_packidx_get_packfile_path() for library-internal use

diff | patch | tree

Stefan Sperling

fix open file descriptor leak in error path of read_object_header_privsep()

diff | patch | tree

Stefan Sperling

implement raw object data access; this will be required for packing

diff | patch | tree

Stefan Sperling

make close(2) failure checks consistent; check 'close() == -1' everywhere

ok millert, naddy

diff | patch | tree

Stefan Sperling

make fclose(3) failure checks consistent; check 'fclose() == EOF' everywhere

ok millert, naddy

diff | patch | tree

Stefan Sperling

fix path existence check in got_object_tree_path_changed()

A symptom of this was a segfault in 'got blame distrib/miniroot/install.sub' with the OpenBSD src.git from github, reported by jrick. The problem was that the commit graph traversed one commit too far. This could be more easily reproduced with 'got log': got log -c 05f568 -P distrib/miniroot/install.sub Which listed two commits instead of just the first one: 05f568ecc6aadefa1aff9064a29e798874a71409 <-- install.sub first created here 7c0d87f00e480cdf004324dad6f3e6f4418f8f42 "distrib/miniroot" exists in 7c0d87f00e480cdf004324... but not in the parent of this commit. Ensure that we traverse the full path in tree1 even if an intermediate tree2 cannot be opened. Instead of reporting success and a file change if we can't traverse further through tree2, we now hit this failing attempt to open the file 'install.sub' in tree object 180aa33df8d1 (tree1): te1 = find_entry_by_name(tree1, seg, seglen); if (te1 == NULL) { err = got_error(GOT_ERR_NO_OBJ); goto done; } fix tested and ok jrick

diff | patch | tree