Commits
- Commit:
0f5f58bba93f6b0a435fdf59157ef453a2291ba1
- From:
- Stephen J Day <stephen.day@docker.com>
- Date:
channel: truncate twrite messages based on msize
While there are a few problems around handling of msize, the easiest to
address and, arguably, the most problematic is that of Twrite. We now
truncate Twrite.Data to the correct length if it will overflow the msize
limit negotiated on the session. ErrShortWrite is returned by the
`Session.Write` method if written data is truncated.
In addition, we now reject incoming messages from `ReadFcall` that
overflow the msize. Such messages are probably terminal in practice, but
can be detected with the `Overflow` function.
Tread is also handled accordingly, such that the Count field will be
rewritten such that the response doesn't overflow the msize.
Signed-off-by: Stephen J Day <stephen.day@docker.com>
- Commit:
529e2b2efc36aab8a17e32ba2516fc89d4cbd43a
- From:
- Stephen Day <stevvooe@users.noreply.github.com>
- Via:
- GitHub <noreply@github.com>
- Date:
Merge pull request #33 from stevvooe/new-context
p9p: use new context package throughout
- Commit:
be903fb70e1321c4a6bf326a59df71d618fc4fc7
- From:
- Stephen J Day <stephen.day@docker.com>
- Date:
p9p: use new context package throughout
Signed-off-by: Stephen J Day <stephen.day@docker.com>
- Commit:
f717cf67aaf232164ee121c1d3b1ef669808e94f
- From:
- Stephen Day <stevvooe@users.noreply.github.com>
- Via:
- GitHub <noreply@github.com>
- Date:
Merge pull request #28 from simonferquel/msize_negociation_fix
Fixes the MSize comparison when negociating msize with server
- Commit:
b8387ce465d350c920f5c07d465c96b9f0ec76e1
- From:
- Simon Ferquel <simon.ferquel@docker.com>
- Date:
Fixes the MSize comparison when negociating msize with server
Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
- Commit:
5a239064dbe9aba79f7f9796b4aea7b74cef30fc
- From:
- Stephen Day <stevvooe@users.noreply.github.com>
- Via:
- GitHub <noreply@github.com>
- Date:
Merge pull request #23 from dominikh/qtype
Specify type for all constants, not just the first
- Commit:
b9021eb7ca84c51453365c9814d3a04afa909bb9
- From:
- Stephen Day <stevvooe@users.noreply.github.com>
- Via:
- GitHub <noreply@github.com>
- Date:
Merge pull request #24 from stevvooe/refactor-transport-close
transport: remove race condition on close
- Commit:
f970a77fb3ab248e66b440d09fb65f9d158d42ed
- From:
- Dominik Honnef <dominik@honnef.co>
- Date:
Specify type for all constants, not just the first
Closes #22
Signed-off-by: Dominik Honnef <dominik@honnef.co>
- Commit:
d98997ce17d033b6b46fb16f9845aaa7cdff4428
- From:
- Stephen J Day <stephen.day@docker.com>
- Date:
transport: remove race condition on close
Signed-off-by: Stephen J Day <stephen.day@docker.com>
- Commit:
4f41ff66898913697507fdf8ebb75d811715b81a
- From:
- Stephen Day <stevvooe@users.noreply.github.com>
- Via:
- GitHub <noreply@github.com>
- Date:
Merge pull request #21 from nilium/fix-close-error-race
Fix race-y channel close/error assignment
- Commit:
87c6cf4550e8bf9dac847f1c6437e453aadef7c8
- From:
- Stephen Day <stevvooe@users.noreply.github.com>
- Date:
Merge pull request #20 from docker/fix-alignment
Fix readme alignment
- Commit:
f8c69a179645d6b19ee60c05c3ab4e6725a49ccc
- From:
- Noel Cower <ncower@gmail.com>
- Date:
Fix race-y channel close/error assignment
Data race occurred when assigning to err and then subsequently reading
it from anywhere else. Moving the channel close down could potentially
help, but far easier to just gate both with a sync.Once since this
isn't a code path that seems like it needs to be super-performant.
Changes cause CloseWithError to be call-able once, ensuring that
there's no case where err is written to while being read (as would
happen when closing and reading c.err from another goroutine the moment
c.closed is closed).
Signed-off-by: Noel Cower <ncower@gmail.com>
- Commit:
5b5b3339079dd9869ac83f70b7993a0ae0363750
- From:
- French Ben <frenchben@docker.com>
- Date:
Fix readme alignment
Signed-off-by: French Ben <frenchben@docker.com>
- Commit:
ac8248b9d483c8caf31e56bf7930cd7fa26b1658
- From:
- Stephen Day <stevvooe@users.noreply.github.com>
- Date:
Merge pull request #19 from docker/badge-badge
Added badge badge
- Commit:
50a8a16a89824975e76df0c5fd2202ea54ef345e
- From:
- French Ben <frenchben@docker.com>
- Date:
Merged master
Signed-off-by: French Ben <frenchben@docker.com>