Commits
Commit:
18223c2807bc7cc41327d84c187934fd2730d277
From:
Omar Polo <op@omarpolo.com>
Date:
Mon Jun 13 18:01:58 2022 UTC
reset path buffer before writing to it otherwise path, which is filled by the garbage that's on the stack, may not end with a NUL byte. main_enqueue fails with "malformed data" if the path sent doesn't end with a NUL. (i.e. the fact that in every case the path is NUL-terminated is not relevant. For semplicity, I'm working with paths long PATH_MAX bytes and only checking that path[PATH_MAX-1] is NUL when handling the imsgs.) Issue reported by Dirk-Wilhelm Peters, thanks!
Commit:
a830518b711387c072755100b8c6d9142b19656e
From:
Omar Polo <op@omarpolo.com>
Date:
Thu Jun 9 17:21:46 2022 UTC
use a strictier pledge for `amused add' now that we're using canonpath instead of realpath(3), we can drop the rpath pledge promise.
Commit:
ef593b43ed4d545943bfb6ebdcc0b8a9c9450cd1
From:
Omar Polo <op@omarpolo.com>
Date:
Thu Jun 9 17:18:55 2022 UTC
use canonpath instead of realpath(3) so we get the same behaviour with `add' and `load'
Commit:
96233476c269f24ce76cecadc2f5144632157d7b
From:
Omar Polo <op@omarpolo.com>
Date:
Thu Jun 9 17:17:35 2022 UTC
use canonpath (from kern_pledge.c) instead of home grow "equivalent"
Commit:
d903ec9aae187a608670f040d40a89ca1fed243a
From:
Omar Polo <op@omarpolo.com>
Date:
Sun May 29 08:38:17 2022 UTC
drop a local variable don't need to keep `files' around, res->files is enough. it would have prevented the previous bug (probably.)
Commit:
a185ed1ea0aa9e48c5cc2708ee45ef4c80bd4277
From:
Omar Polo <op@omarpolo.com>
Date:
Sun May 29 08:36:38 2022 UTC
fix `amused add' failure introduced in previous commit don't advance the files pointer, we need the original pointer when receiving the replies.
Commit:
fad0fb69c1b7616f933c497887967078ff4dd111
From:
Omar Polo <op@omarpolo.com>
Date:
Sat May 28 21:18:08 2022 UTC
refactor: group imsg handling the approach with one-function-per-imsg leads to too much code splatted across the file.
Commit:
90122a37e6f55f08fd979f7b07ba20a49952faf8
From:
Omar Polo <op@omarpolo.com>
Date:
Sat May 14 18:54:20 2022 UTC
amused monitor: allow to pass a list of event as filter it's easier / simpler for scripts to do $ amused monitor next,prev,jump rather than $ amused monitor | egrep --line-buffered 'next|prev|jump'
Commit:
d51201063dfd08d55382bc1848cee7f4662f504b
From:
Omar Polo <op@omarpolo.com>
Date:
Sat Mar 26 18:51:30 2022 UTC
add back missing memzero
Commit:
1dd3b054dd3d8778debf24bb32cc61ff06e3ee42
From:
Omar Polo <op@omarpolo.com>
Date:
Fri Mar 25 22:45:03 2022 UTC
use a more readable strncmp to look for prefixes also while here stick an `else' before the second clausole. We're supposed to trim out only '> ' and ' ', but the missing else would also trim out ' ' after a '> '!
Commit:
c00c1428ccaedc2d63d9d489c00d796d5718f615
From:
Omar Polo <op@omarpolo.com>
Date:
Fri Mar 25 22:45:03 2022 UTC
get rid of realpath during load it has a non-ignorable cost over NFS (sdk@ reported ~30 seconds to load 64k songs, and up to 5 minutes over wifi!) and don't provide us any real gain: files can still vanish after being imported or may appear later. The only advantage of realpath was that it would clean up the path from segments like "/./" and resolve the ".." components, but that's a minor issue anyway. prodded by, discussed with and tested by sdk@, thanks a lot!
Commit:
335fa83ad847d6b5b891ec166625907be664ab5d
From:
Omar Polo <op@omarpolo.com>
Date:
Wed Mar 9 09:18:38 2022 UTC
drop now unused #include <sndio.h> with the recent refactoring, sndio is only visible in player.c
Commit:
acaf7eb251046be1f73077acf6519aa7496fa0a4
From:
Omar Polo <op@omarpolo.com>
Date:
Sat Mar 5 11:02:30 2022 UTC
fix argc check argc can be -1 if we called noarg with argc=0, because optind is 1.
Commit:
7e29fc4a3e7217cea06735afda36eac20159ae18
From:
Omar Polo <op@omarpolo.com>
Date:
Thu Mar 3 14:29:41 2022 UTC
correctly handle arguments for sub-commands things like "--" should be skipped etc, easier to rely on getopt(3).
Commit:
f44b3c4e5f075af1be265b896f3fcb320c831ad8
From:
Omar Polo <op@omarpolo.com>
Date:
Thu Mar 3 13:53:31 2022 UTC
output the two repeat bits in two different lines
Omar Polo