Commits
- Commit:
3d6e5cb56a6249e7f3001091fe81c171cd501319
- From:
- Russ Cox <rsc@swtch.com>
- Date:
acme: preserve window position and selection during Get
Before, executing Get in a file rewound the window offset and
selection to the start of the file.
After this CL, Get preserves the window offset and selection,
where preserve is defined as "the same line number and rune
offset within the line". So if the window started at line 10
before and the selection was line 13 chars 5-7, then that
will still be true after Get, provided the new content is large
enough.
This should help the common situation of plumbing a
compiler error, realizing the window is out of date,
clicking Get, and then losing the positioning from the
plumb operation.
- Commit:
67dbeee5fe9e2a855384048615bafe100e876f4c
- From:
- Russ Cox <rsc@swtch.com>
- Date:
acme: check file content before declaring file "modified since last read"
Bad remote file systems can change mtime unexpectedly,
and then there is the problem that git rebase and similar
operations like to change the files and then change them back,
modifying the mtimes but not the content.
Avoid spurious Put errors on both of those by checking file
content.
(False positive "modified since last read" make the real ones
difficult to notice.)
- Commit:
b15fd97627767291628309677c40b3f40b868497
- From:
- Russ Cox <rsc@swtch.com>
- Date:
acme: implement Cmd-Shift-Z for Redo on Mac
Change-Id: Ie9332ed473609bd6ca156be0843dc5411cbf7b93
Reviewed-on: https://plan9port-review.googlesource.com/2941
Reviewed-by: Russ Cox <rsc@swtch.com>
- Commit:
fff818fe878ca5edfbac85b15e77ada2acb8ea0f
- From:
- Russ Cox <rsc@swtch.com>
- Date:
libdraw, libframe, acme: fix, guard against inverted range in textsetselect
Credit to Roi Martin <jroi.martin@gmail.com> for noticing that
libdraw was being passed a negative string length and for finding the
sequence of keystrokes that make acme do it reproducibly.
Change-Id: If3f3d04a25c506175f740d3e887d5d83b5cd1bfe
Reviewed-on: https://plan9port-review.googlesource.com/1092
Reviewed-by: Russ Cox <rsc@swtch.com>
- Commit:
50ababbd552abfa8ef3b16ccdaea54b58f5c031c
- From:
- Russ Cox <rsc@swtch.com>
- Date:
acme: fix bufread crash due to typing-point scrolling
Acme tracks the most recent typing insertion point and
the home and end keys stop there on their way
up to the top or down to the bottom of the file.
That point should be iq1, and it should be adjusted
properly so that it's always between 0 and t->file->b.nc inclusive.
(This is all code from an external contributor, years old at this
point but new since Plan 9.)
Somehow, sometimes iq1 ends up a little beyond b.nc,
and when passed to textbacknl it crashes acme in bufread.
I can't see how that can happen but if it does, avoid the crash.
It's tempting to pull the insertion point code out entirely
but this is a little less invasive and should fix things for now.
TBR=rsc
https://codereview.appspot.com/107730043
- Commit:
113ea95f7b3b8f2af5e57214fe752c187d35aa19
- From:
- Russ Cox <rsc@swtch.com>
- Date:
undo CL 69070045 / 8539a916d98a
This breaks ^C in win windows, as expected.
People use ^C, win expects and handles ^C,
so I don't think we can just take it away.
I've noticed that it is broken but assumed my ssh
was screwed up.
If you want to make WindowsKey+C,X,V do the
operations, by analogy with command+C,X,V
on Mac, that's fine with me.
««« original CL description
acme: copy/cut/paste with ctl+c,x,v
LGTM=rsc
R=rsc
CC=plan9port.codebot
https://codereview.appspot.com/69070045
»»»
TBR=rsc
CC=burns.ethan, r
https://codereview.appspot.com/96410045
- Commit:
d213189122bb3cd509cfe706240ffea528fee5f2
- From:
- Russ Cox <rsc@swtch.com>
- Date:
acme: fix Get of dir in nameless window (thanks Colton Lewis)
TBR=r
https://codereview.appspot.com/89390043
- Commit:
4030a6c905c99c48e7ca714fbe17a9b00fbff6fe
- From:
- Ethan Burns <burns.ethan@gmail.com>
- Via:
- Russ Cox <rsc@swtch.com>
- Date:
acme: copy/cut/paste with ctl+c,x,v
LGTM=rsc
R=rsc
CC=plan9port.codebot
https://codereview.appspot.com/69070045
- Commit:
5a69e405fcae96b476cdd7a0767e87b94c0b7266
- From:
- Rob Pike <robpike@gmail.com>
- Date:
acme: scroll a directory window when navigating if:
- the cursor is on the last line
- the navigation would put the cursor over the tag of the following text
R=rsc
CC=smckean83
https://codereview.appspot.com/15280045
- Commit:
81c30b5a75cb5ae9a5175321a5f8a6049f0ac4e3
- From:
- Sean McKean <smckean83@gmail.com>
- Via:
- Russ Cox <rsc@swtch.com>
- Date:
acme: fix arrow near end of text
R=rsc
CC=plan9port.codebot
http://codereview.appspot.com/5399050
- Commit:
a287dbab235c9041a32300a9e0bb60ef41864963
- From:
- David Jeannot <djeannot24@gmail.com>
- Via:
- Russ Cox <rsc@swtch.com>
- Date:
devdraw: draft cocoa support
R=rsc
CC=plan9port.codebot
http://codereview.appspot.com/4974060
- Commit:
da7e3a5d39b3acf930ca5714aed4826435cb1e13
- From:
- Russ Cox <rsc@swtch.com>
- Date:
acme: fix iq1 adjust bug
R=rsc
http://codereview.appspot.com/4816066
- Commit:
76864eb6cd2759efd687f392ada4f1facbf06250
- From:
- Russ Cox <rsc@swtch.com>
- Date:
acme: scrolling fixes + new home/end
Home and End previously navigated between
two different window locations: the top and
the bottom of the text. Now they include a
third waypoint: the location where typing last
happened. Thus, in a win window, typing
ls -l
<home>
scrolls to the beginning of the ls -l output.
A second <home> continues to the top of the file.
Makes Send scroll always, along with writes by
external programs to +Errors.
R=r
CC=mccoyst
http://codereview.appspot.com/4830051
- Commit:
daea2c7d501c3e825bede80992ade6b241efdce1
- From:
- Russ Cox <russcox@gmail.com>
- Date:
acme: correct modified message after initial load; more detail in
message
http://codereview.appspot.com/123051
- Commit:
4dbf255619efac4f0a00e4216d6c999128910df2
- From:
- Russ Cox <russcox@gmail.com>
- Date:
acme: htmlclick takes precedence over line click
http://codereview.appspot.com/116074