Commits
- Commit:
2c52c623be04b56400a5c94cc8d86b6fda214d16
- From:
- Omar Polo <op@omarpolo.com>
- Date:
convert to use imsg_get_fd()
While here also fix a fd leak in got-read-pack. We were dup'ing
imsg.fd without closing imsg.fd later; instead just use imsg_get_fd()
to extract the file descriptor.
Tested by falsifian and Kyle Ackerman, thanks!
'go ahead' stsp@
- Commit:
76a9a38e0c199dfd2ee26f23792b56e2b77952c2
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix swapped format string arguments in gotd verify_imsg_src()
- Commit:
56624d2b65c2b867ab6c9dd5ac2ad51c3a13d47c
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
make the gotd auth process provide the user's account name for later use
with tweaks from + ok op@
- Commit:
abe89edb698f9d165b74d1fe146b13fade5b52bd
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
allow gotd repo read/write processes to max out data-size resource limits
Proccessing large pack files can easily result in out-of-memory errors
if the datasize limit is too conservative.
- Commit:
1050403b806ca85666ad4b6a9e83953fdbb5298a
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
gotd: stop logging "unexpected end of file" when a client decides to disconnect
- Commit:
5fb50fce7978aa218c87ec7ac6c3f4e7bf20e5b3
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix typo in a comment
- Commit:
4b3827cd43394b89d2af822dcd1d9a9179c1ee10
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
make gitwrapper ignore 'permission denied' for repository paths
We recommend that gotsh users should not have direct filesystem
access to repositories served by gotd. Which means admins will be
setting things up as follows if public read-access should be denied:
chown _gotd /git
chmod 700 /git
su -m _gotd -c 'gotadmin init /git/repo.git"
However, gitwrapper would error out when repositories listed in
gotd.conf were inaccessible to the user invoking gitwrapper:
git-upload-pack: /etc/gotd.conf:2: realpath /git/repo.git: Permission denied
Make gitwrapper ignore such errors as they are expected in this situation.
While here, add a PROC_GITWRAPPER process ID for use as a global variable
parse.y can check while special-casing any specific behaviour required by
gitwrapper. (The worse alternative would have been adding a new global
variable to parse.y just to control the behaviour on realpath errors.)
ok op@
- Commit:
839338f6ab1254d6d0709f19db60b164269288d5
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotd: wait asynchronously for children termination
Instead of the current kill() + waitpid(WNOHANG), manage the
subprocesses in a separate queue and handle SIGCHLD. A timer is
installed to ensure that misbehaving subprocesses are still killed.
Fixes the current "child PID 0 terminated" logs due to races with
waitpid(). Issue initially reported by Josiah Frentsos.
ok + tweaks stsp@
- Commit:
ba91039c1a0a3d55f4850e26c24730cbf4b5c239
- From:
- Omar Polo <op@omarpolo.com>
- Date:
add kill_repo_proc() similarly to the other kill_*_proc()
ok stsp@
- Commit:
a328bb1b14dfe7d99e5d66c3fab2d5ebe4c4119a
- From:
- Omar Polo <op@omarpolo.com>
- Date:
missing semicolon... sigh
I can't assume I can blindly add one simple line.
- Commit:
c929736a36ab9616de454d901bd908e0c9512a26
- From:
- Omar Polo <op@omarpolo.com>
- Date:
move gotd_child_proc to gotd.c
make it opaque since it's unused outside of gotd.c. While here,
drop the unused `nhelpers' field.
ok/tweak stsp@
- Commit:
ce986f226790f56efc0cbece296c912d25385599
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
update gotd_proc_names after session process unveil changes
fixes "proc (null)" appearing in gotd logs
- Commit:
b061482840b244c4645851c4a02a9ce9723b9fc5
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
unveil repositories read-only in gotd session process while serving fetches
ok op@
- Commit:
c000aa350eac5ac329beb278a513e5f978d2a463
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
gotd: return early after disconnect on auth event error
This fixes a segv reported by Mikhail. In this path, any error is already
logged, client freed, and event_del() called so we don't need to cleanup
in done.
ok stsp@
- Commit:
9afa3de221045d529287cc3fa75fdc2915aed5c1
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
add support for protecting references against 'got send -f' to gotd
ok op@