Commits
- Commit:
04666d1a54c25c8be7e39bc628b4a80f3376c127
- From:
- Omar Polo <op@omarpolo.com>
- Date:
got: fflush(stdout) after asking questions
Not everywhere getline does an implicit fflush, so we might end up not
showing the prompt to the user. Spotted on alpine with muslc.
ok Thomas Adams
- Commit:
442ede73eadb025cdc45bede186bf31aee869dad
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
forbid rebase of references outside the refs/heads/ namespace
ok jrick
- Commit:
8d4a8ca19cca1354c4d99d5df888c3c9b56e075c
- From:
- Josh Rickmar <jrick@zettaport.com>
- Date:
Do not segfault verifying "lightweight" tags
ok stsp@
- Commit:
5e91dae4dd43b8024731223110ab18f505f453ac
- From:
- Josiah Frentsos <jfrent@tilde.team>
- Via:
- Stefan Sperling <stsp@stsp.name>
- Date:
remove trailing whitespace; patch by Josiah Frentsos
- Commit:
360f3aea9198de6c93e8a185f87641b59c96dbfe
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
got: fix typo in argc check when diffing two blobs
We already have two arguments when diffing two blobs, so check for more than
two like we do when diffing two objects to check for invalid path args.
Includes new regress test by op for diffing two blobs.
ok stsp@ and ok plus regress test from op@
- Commit:
85f2c2e0132ed34974446382474602b11d336f3a
- From:
- Omar Polo <op@omarpolo.com>
- Date:
fix overflow in blame callback
spotted by noticing gotwebd crashing on some blame requests.
Diff from stsp@ with a fix from tracey@, I'm committing it only because
he is short on time.
ok stsp@
- Commit:
438d0cc30baf8e97fd870f5e620833e0a45401aa
- From:
- Omar Polo <op@omarpolo.com>
- Date:
fix snprintf error handling
follow the "proper secure idiom" described in the CAVEATS section of
printf(3). reminded by tb@ and millert@
- Commit:
827a167b34401bd6541b199377e4e6c68d643151
- From:
- Josiah Frentsos <jfrent@tilde.team>
- Via:
- Stefan Sperling <stsp@stsp.name>
- Date:
Group options in accordance with style(9)
patch by Josiah Frentsos
- Commit:
d30ab56fff40b038af410d963b66e866a8e4e528
- From:
- Christian Weisgerber <naddy@mips.inka.de>
- Date:
fix unused variable, function definition warnings for clang 15
- Commit:
8fb6814c7fc92dbee5d95b1c66383d00bfa60f49
- From:
- Omar Polo <op@omarpolo.com>
- Date:
avoid allocating too many errors in cmd_info
got_error_path uses get_custom_err to get a statically allocated error
allocated on a buffer that's used a ring. This is nice and simple, but
the drawback is that thees custom errors shouldn't be used "for too
long" because they might get overwritten later.
cmd_info is one offender: change it to store a "simple" error and later
re-use it to construct the per-path error.
OK and tweaks stsp@
- Commit:
3ef734a17cb66c5ec85cdacaddc8be15237dcf69
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix "got tag" not tagging the work tree's current branch by default
found by jrick
- Commit:
c7d5c43cafada3470647a8b876d489018002f713
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
tog: keymaps to jump to next/prev file/hunk in the diff
Add () and {} key maps to navigate to the previous and next file or hunk in
the diff. This required changing Got's diff API to collect line type metadata
in addition to the line offsets already produced as prompted by stsp.
ok stsp@
- Commit:
5f56d41e1acd9cce7202960acad0cab3516e9c26
- From:
- Omar Polo <op@omarpolo.com>
- Date:
got patch: add -c flag to apply at a specified commit
it's useful for e.g. to apply old patches that weren't generated by `got
diff' or git-diff(1) and so lacks the metadata needed for the 3-way
merge.
manpage improvements from and ok stsp@
- Commit:
2ed050c519e5d5706f53064a0e604533244ff969
- From:
- Omar Polo <op@omarpolo.com>
- Date:
`got patch' pledge early
ok stsp@
- Commit:
595228385f8c74590756ff446d5b84aad0ebfda7
- From:
- Omar Polo <op@omarpolo.com>
- Date:
got patch: error if patchfile isn't a regular file
`got patch' cannot read patches from non-regular files for obvious
reasons. However, it could crash in sendmsg because pledge doesn't
allow to send file descriptors referring to directories. So, restrict
`got patch' to operate on regular files only and fail otherwise.
This still allows to read patches from symlinks since they're resolved
at open(2) time and the file type check is performed after.
There may be a marginal usefullness in reading patches from fifos, but
the current code doesn't allow that anyway since got-read-patch needs a
seekable file descriptor anyway.
ok tracey@