Commits


fix my email address used @openbsd.org initially by mistake and got copied around in most files. Since this has nothing to do officially with the OpenBSD project, use my own email address.


drop notify_seek var; always notify on seeks First move towards a change in the behaviour of `monitor': advancement on tracks during the play are reported also every second, as the music is played, not only when there's an explicit seek.


add consume mode the consume mode implicitly drops the tracks from the playlist when played 'till the end (note that skipping over a track doesn't trigger the consume mode - yet?)


monitor: fix reported event rethink a bit which event are reported and when. - drop 'toggle' event as it's not useful; now 'amused toggle' will report the play/pause event. - replace 'flush' with 'load'. there's no real difference between a flush and an empty load. (also, less event the better) - some events (next/prev/jump) are reported earlier to avoid possible issues (when messing around with the playing queue we can end up in every possible state.) - report 'seek' only after it really happened (i.e. after the player process sent the new position.) There's still a possible race here (we can receive a previous IMSG_POS and think it's the reply to the seek) but it it's hard/impossible to work around. - drop 'restart'. we have 'seek' now which is better (and actually restart is implemented on top of seek.) - add 'seek' to the default list of events.


refactor control_notify it's awkward to call it with the address of the imsgev struct inside the ctl_conn struct. Just relay the info to every client in monitor mode. After all, if a client is in monitor mode *and* issues commands, it's not strange that they're echoed back (note that this is currently impossible, the command line client can either issue commands or be in monitor mode.)


reimplement `restart' on top of seek


use (a modified version of) kristaps' oconfigure see GitHub issue #1


implement seeking This adds the internal management of the seeking, as well as the decoder backends bits.


declare local functions as static


keep track of current position and total duration


improving error reporting makes the player process optionally send back a string describing the failure to provide a better and more coincise error message. This turns the syslog message(s): amused: unknown file type amused: failed to play, skipping /home/op/pics/phos.jpg into: amused: unknown file type; skipping /home/op/pics/phos.jpg


skip every non-regular file not only directories... I guess we can't do much even with sockets, fifos or character devices. (symbolic links are still supported since we follow them)


drop unnecessary temp variable in main_restart_track


avoid unnecessary initialization we're just gonna memcpy all over path again a couple of lines before; a smart compiler will probably ignore the initialization anyway.


simplify main_send_player: data is always NULL