Commits
- Commit:
4448825ab554378228429f5ac53c9cf943cc2503
- From:
- Omar Polo <op@omarpolo.com>
- Date:
dropping unnecessary strlen()s
ok jamsek, stsp
- Commit:
23c35dae297d2eecd13e17118a547761314a578d
- From:
- Omar Polo <op@omarpolo.com>
- Date:
change got_get_repo_tags' limit argument to size_t
The function already carefully avoids wrapping around zero. While
here add a sanity check for limit == 0, like what was previously done
for got_get_repo_commits().
- Commit:
0a2fc48663670b6fb1a778aafc653227c9103442
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: make got_get_repo_commits take a size_t
and while here make sure 0 is rejected.
requested by, improvements and ok stsp@
- Commit:
5144d22b0c3bcf6611cc36e93a3a859fcc521277
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: simplify got_get_repo_commits(): don't traverse all the commits!
In some cases (e.g. limit=1 for DIFF action) we could end up traversing
all the commits instead of fetching just the one requested. Needless to
say, this makes the diff page extremely slow.
reported by and ok stsp@
- Commit:
50f6148a8cb54672795a89ce089488e86f584a0e
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: fix some got_error_from_errno2/3 calls
it's not printf-like so %s don't make sense. Tweak the order of
the arguments to obtain the intended output.
- Commit:
f06465966b88928c2801b7d9ecb36c3a7c5e36b4
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: avoid needless double fseek()
got_gotweb_closefile() already takes care of rewinding before
truncating and closing, so no need to replicate here.
ok stsp@
- Commit:
8a078d7f1359fdf37e7bc18d6ace3c3579b98b33
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: lower log priority of unexpected disconnections
no need to be so loud when a client disconnects earlier than expected,
log it only in verbose mode. Don't log GOT_ERR_CANCELLED too since
that is only used to communicate the callers that we need to stop.
ok stsp@
- Commit:
29efeeddc18828c36f1a6df50e05297a51a1a396
- From:
- Omar Polo <op@omarpolo.com>
- Date:
oops, one was missing
- Commit:
4e3e8516c9205eb93e0203a60fd74e271f567adb
- From:
- Omar Polo <op@omarpolo.com>
- Date:
got_operations.c: use consistently a space before labels
makes diff prettier and easier to read; instead of the label we
have the function name in the hunk line.
- Commit:
d20cd3851233c5fcfd89337f428bf85b45f1f6d7
- From:
- Omar Polo <op@omarpolo.com>
- Date:
remove fsync() from got_gotweb_closefile()
discussed with millert@
- Commit:
24a4d8019b7b2937f03fc86f47048f599ec6617c
- From:
- Omar Polo <op@omarpolo.com>
- Date:
rename got_gotweb_flushfile -> got_gotweb_closefile
suggested and ok millert@
- Commit:
08ea2d1b208deaafa404f05069a578e4c58a9a6d
- From:
- Omar Polo <op@omarpolo.com>
- Date:
make got_gotweb_flushfile always close the file
ok millert@
- Commit:
e62232ad5eede7312d40cef9a300a4c74ea91eda
- From:
- Omar Polo <op@omarpolo.com>
- Date:
rename some local fdN vars after previous change
- Commit:
18069c98fe9366115c4daff243a6c0afe5069d3c
- From:
- Omar Polo <op@omarpolo.com>
- Date:
simplify got_gotweb_openfile/flushfile
Return only the FILE *, and require only that to close subsequently.
Having to manage the file descriptor too makes using these functions
unnecessary complex.
millert@ agrees
- Commit:
5822e79e39a8777984e08b5d89a8c55d6aa0356d
- From:
- Omar Polo <op@omarpolo.com>
- Date:
include sha2.h too where sha1.h is included
In preparation for wide sha256 support; stsp@ agrees. Change done
mechanically with
find . -iname \*.[cy] -exec sam {} +
X ,x/<sha1\.h>/i/\n#include <sha2.h>