Commits


remove unnecessary includes of got_lib_privsep.h


move functions which open objects into new file object_open_privsep.c For the future, this will make it possible to provide alternative implementations of functions now stored in object_open_privsep.c. This will probably be needed by future gotd(8) which runs inside a chroot(2) environment and without the "exec" pledge(2) promise, making it impossible to run libexec helpers on the fly. Details of this design are not yet settled, but moving functions into a separate compilation unit won't hurt in any case.


drop unconventional got_object_commit_dup() routine Replace with got_object_commit_retain() to increment commit object reference counter. suggested by and ok stsp@


tog: add new log view limit feature to filter commits Use the & key map to enter a pattern with which to limit the displayed commits to those matching the provided pattern; similar to less(1) and mutt's limit feature. Includes various tweaks from op. ok plus fixes from op@


plug leak in resolve_symlink ok stsp@


remove trailing whitespace; patch by Josiah Frentsos


move got_opentempfd() out of lib/diff.c again ok tracey


pass the correct file to fdopen(); ok tracey


fix missed dup in open_blob per stsp@


move got_opentempfd out of open_blob. ok stsp@


allow start_pack_privsep_child() to be called from outside lib/object.c


build with -Wmissing-prototypes ok stsp@


let got-read-pack be explicit about whether it could enumerate all objects This allows the main process to avoid looping over all object IDs again in case the pack file used for enumeration is complete. ok op@


Bring back object enumeration inside got-read-pack as a fast path. The problem that was found in the earlier version has been fixed. ok op@


revert object enumeration in got-read-pack for now; needs more work This implementation marked commits and trees as enumerated before all trees which they depend on were enumerated. This behaviour leads to incomplete pack files when a tree is only partially packed and got-read-pack hits a missing tree entry as a result. The algorithm must be reworked such that packed leave nodes are marked enumerated first, then bubble-up. Found by op@