Commits
- Commit:
738d9f00ebea340b28d1f859f5f39c1ad6fb0fd0
- From:
- Omar Polo <op@omarpolo.com>
- Date:
use getprogname(3) instead of __progname
might help with portability, see for e.g. GitHub issue #1
- Commit:
e06ad444a2ebf4c3ef8c41c6f4fa74f358f205be
- From:
- Omar Polo <op@omarpolo.com>
- Date:
avoid unnecessary initialization
we're just gonna memcpy all over path again a couple of lines before; a
smart compiler will probably ignore the initialization anyway.
- Commit:
fd90976c2bb3674cfbf4ffd5ad0fcec51a64da18
- From:
- Omar Polo <op@omarpolo.com>
- Date:
free the imsg in player after handling, plugs a memory leak
- Commit:
6e4f8947cd1b33dc0004236e614d704377353f24
- From:
- Omar Polo <op@omarpolo.com>
- Date:
inline player_enqueue
- Commit:
ee5ab27dda2f3da5cd6a38ec0d4d4c9e6a5b6c48
- From:
- Omar Polo <op@omarpolo.com>
- Date:
s/audio_init/player_init
was the only function to disrespect the player_* namespace (well,
excepting play). while here also don't mark those two as static, they
were the only static functions in the file. I'm not trying to
enforcing private symbols here.
- Commit:
7850bef5851db3b13284bfaae7cede92b8450aff
- From:
- Omar Polo <op@omarpolo.com>
- Date:
no need to sio_setpar during initialization
we don't know what format the music will be so we have to stop and set
the parameters in player_setup. there's no point in setting bogus
parameter in audio_init.
- Commit:
d903ec9aae187a608670f040d40a89ca1fed243a
- From:
- Omar Polo <op@omarpolo.com>
- Date:
drop a local variable
don't need to keep `files' around, res->files is enough. it would have
prevented the previous bug (probably.)
- Commit:
a185ed1ea0aa9e48c5cc2708ee45ef4c80bd4277
- From:
- Omar Polo <op@omarpolo.com>
- Date:
fix `amused add' failure introduced in previous commit
don't advance the files pointer, we need the original pointer when
receiving the replies.
- Commit:
fad0fb69c1b7616f933c497887967078ff4dd111
- From:
- Omar Polo <op@omarpolo.com>
- Date:
refactor: group imsg handling
the approach with one-function-per-imsg leads to too much code
splatted across the file.
- Commit:
5f42a6c6cec1b37dd9f653a36d005b5dc1c58be0
- From:
- Omar Polo <op@omarpolo.com>
- Date:
try to recover from mp3 decoding errors
- Commit:
ef3501c14ba82ac6ef0f65e637481b4f43fde937
- From:
- Omar Polo <op@omarpolo.com>
- Date:
bump version number
- Commit:
e87b9802208746b0a6fa58f3683a16f8a2e7ab98
- From:
- Omar Polo <op@omarpolo.com>
- Date:
CHANGES for 0.7
- Commit:
b0d2a96623a89cfe946be257db54d6099b394da8
- From:
- Omar Polo <op@omarpolo.com>
- Date:
tweak -d description
- Commit:
500432f1a3a0f9ab14241388c9220c5c29ce0cf5
- From:
- Omar Polo <op@omarpolo.com>
- Date:
typo
- Commit:
926ee8364e8c83d7a22dcd5bceb65e235486703a
- From:
- Omar Polo <op@omarpolo.com>
- Date:
consume all enqueued messages before calling imsg_read
player_dispatch reads only one imsg from the ibuf. Next time it's
called, the other messages on the ibuf (if any) are discarded and new
ones are read. This can cause the player process to go out-of-sync with
the main process if multiple messages were "bundled" in the same chunk.
To avoid this, always try to imsg_read before. If it succeedes, we read
process the equeued messages one by one, if it fails then we poll for
new data and call imsg_read to process them and retry.
This fixes a bug where amused could be "confused" by running
$ amused pause ; amused stop ; amused play
in a loop a few times. This bug and the repro were reported two months
ago by Dirk-Wilhelm Peters, thanks! (and sorry it took so long to
understand and fix the issue)