Commits
- Commit:
c74282f87c41aad90bbd9edc99c3c1fe45d65953
- From:
- Stephen Day <stevvooe@users.noreply.github.com>
- Via:
- GitHub <noreply@github.com>
- Date:
Merge pull request #30 from stevvooe/truncate-twrite-msize
channel: truncate twrite messages based on msize
- Commit:
0f5f58bba93f6b0a435fdf59157ef453a2291ba1
- From:
- Stephen J Day <stephen.day@docker.com>
- Date:
channel: truncate twrite messages based on msize
While there are a few problems around handling of msize, the easiest to
address and, arguably, the most problematic is that of Twrite. We now
truncate Twrite.Data to the correct length if it will overflow the msize
limit negotiated on the session. ErrShortWrite is returned by the
`Session.Write` method if written data is truncated.
In addition, we now reject incoming messages from `ReadFcall` that
overflow the msize. Such messages are probably terminal in practice, but
can be detected with the `Overflow` function.
Tread is also handled accordingly, such that the Count field will be
rewritten such that the response doesn't overflow the msize.
Signed-off-by: Stephen J Day <stephen.day@docker.com>
- Commit:
529e2b2efc36aab8a17e32ba2516fc89d4cbd43a
- From:
- Stephen Day <stevvooe@users.noreply.github.com>
- Via:
- GitHub <noreply@github.com>
- Date:
Merge pull request #33 from stevvooe/new-context
p9p: use new context package throughout
- Commit:
be903fb70e1321c4a6bf326a59df71d618fc4fc7
- From:
- Stephen J Day <stephen.day@docker.com>
- Date:
p9p: use new context package throughout
Signed-off-by: Stephen J Day <stephen.day@docker.com>
- Commit:
4f41ff66898913697507fdf8ebb75d811715b81a
- From:
- Stephen Day <stevvooe@users.noreply.github.com>
- Via:
- GitHub <noreply@github.com>
- Date:
Merge pull request #21 from nilium/fix-close-error-race
Fix race-y channel close/error assignment
- Commit:
f8c69a179645d6b19ee60c05c3ab4e6725a49ccc
- From:
- Noel Cower <ncower@gmail.com>
- Date:
Fix race-y channel close/error assignment
Data race occurred when assigning to err and then subsequently reading
it from anywhere else. Moving the channel close down could potentially
help, but far easier to just gate both with a sync.Once since this
isn't a code path that seems like it needs to be super-performant.
Changes cause CloseWithError to be call-able once, ensuring that
there's no case where err is written to while being read (as would
happen when closing and reading c.err from another goroutine the moment
c.closed is closed).
Signed-off-by: Noel Cower <ncower@gmail.com>
- Commit:
a056819507b3f5113ef8b52f04e67dadf29d8927
- From:
- Stephen Day <stevvooe@users.noreply.github.com>
- Date:
Merge pull request #13 from stevvooe/document-exported-functions
lint/vet: address several issues identified by lint/vet
- Commit:
e363538b1609e4bc46fbdb2783f1fda3172d2d5d
- From:
- Stephen J Day <stephen.day@docker.com>
- Date:
lint/vet: address several issues identified by lint/vet
Signed-off-by: Stephen J Day <stephen.day@docker.com>
- Commit:
63c84aa90a323a2d425c79f41e1f6c3cbdd15547
- From:
- Stephen Day <stevvooe@users.noreply.github.com>
- Date:
Merge pull request #8 from talex5/master
Always negotiate a compatible protocol version
- Commit:
256e7ade568bd33160656b099f53752f08ed01d1
- From:
- Thomas Leonard <thomas.leonard@docker.com>
- Date:
Fix format string error
Error was:
error handling connection error negotiating version:%!(EXTRA *errors.errorString=bad version negotiation) will close
Signed-off-by: Thomas Leonard <thomas.leonard@docker.com>
- Commit:
6b62df4706f86d9f1d38e2dcc363d440561d8c8d
- From:
- Stephen Day <stevvooe@users.noreply.github.com>
- Date:
Merge pull request #1 from stevvooe/flush-race-fix
p9p: address race condition in flush response
- Commit:
c3af85271ab1388caa2b948e638b8e83446d75d4
- From:
- Stephen J Day <stephen.day@docker.com>
- Date:
p9p: address race condition in flush response
Signed-off-by: Stephen J Day <stephen.day@docker.com>
- Commit:
4b33cdd0d581b4485aad245efc054d90f4fabe51
- From:
- Stephen J Day <stephen.day@docker.com>
- Date:
Merge branch 'pinata-filtered'
- Commit:
1f1a1b98065abdda04bc9128e4d8d8202a75bdd1
- From:
- Stephen J Day <stephen.day@docker.com>
- Date:
Merge branch 'pinata-pkg-filtered' into pinata-filtered
Signed-off-by: Stephen J Day <stephen.day@docker.com>
- Commit:
55922182ebf8ddce9bcdd111e24a504549f91259
- From:
- David Scott <dave.scott@docker.com>
- Date:
p9p: remove per-message logging
Printing all requests and responses to the log is quite expensive,
especially when sending megabytes of data through 9P.
This patch leaves the logging in the error paths and the flush path.
Signed-off-by: David Scott <dave.scott@docker.com>