Commits


merge new diff implementation from the git.gameoftrees.org diff.git repository This new diff implementation was started by Neels Hofmeyr during the u2k20 hackathon and now replaces diffreg.c code lifted from the OpenBSD base system. The integration of this code into Got was done by me. Got now uses the patience diff algorithm by default. The diff.git repository will remain the primary repository for the diff code, which already compiles and runs on other operating systems such as Linux. Any fixes and improvements for files inherited from the diff.git repository should be written against that repository and synced to got.git afterwards.


fix replacing symlinks with files And add a test case which verifies that the inverse also works, i.e. a symlink being replaced with a regular file. problem reported and fix tested by jrick


fix missing unlink(tmppath) in error cases of install_blob()


clear staged file type in file index entries whenever staged status is cleared


initialize sb.st_mode after stat(2) failure in got_worktree_resolve_path()


avoid got_repo_map_path() in 'got blame' 'got blame' does not need access to the work tree. So far the work tree was completely hidden with unveil(). We must now expose the work tree while resolving the path, so unveil() calls are shuffled around slightly. Failing realpath() calls would mess with path resolution otherwise. There's a bug in got_worktree_resolve_path() where it failed to canonicalize a path constructed from a user-specified path that does not exist on disk. Note that this path falls into strncmp() a few lines down. I am fixing this by adding canonicalization. Generally, joining paths with asprintf() and comparing paths with strncmp() is fragile. A more general solution might be needed but I am leaving that for another day. ok naddy


convert all remaining instances of chmod(2) to fchmod(2) ok stsp


indentation fixes


plug memory leaks in error paths; found by naddy


use got_path_dirname() in schedule_for_deletion(); avoids const dirname(3) ok naddy


use got_path_dirname() in remove_ondisk_file(); avoids const dirname(3) ok naddy


use got_path_dirname() in install_blob() to avoid const dirname(3) ok naddy


use got_path_dirname() in install_symlink() to avoid const dirname(3) ok naddy


use got_path_dirname() in is_bad_symlink_target() ok naddy


use got_path_dirname() in merge_blob() instead of assuming const dirname(3) ok naddy