Commits
- Commit:
a830518b711387c072755100b8c6d9142b19656e
- From:
- Omar Polo <op@omarpolo.com>
- Date:
use a strictier pledge for `amused add'
now that we're using canonpath instead of realpath(3), we can drop the
rpath pledge promise.
- Commit:
ef593b43ed4d545943bfb6ebdcc0b8a9c9450cd1
- From:
- Omar Polo <op@omarpolo.com>
- Date:
use canonpath instead of realpath(3)
so we get the same behaviour with `add' and `load'
- Commit:
96233476c269f24ce76cecadc2f5144632157d7b
- From:
- Omar Polo <op@omarpolo.com>
- Date:
use canonpath (from kern_pledge.c) instead of home grow "equivalent"
- Commit:
d903ec9aae187a608670f040d40a89ca1fed243a
- From:
- Omar Polo <op@omarpolo.com>
- Date:
drop a local variable
don't need to keep `files' around, res->files is enough. it would have
prevented the previous bug (probably.)
- Commit:
a185ed1ea0aa9e48c5cc2708ee45ef4c80bd4277
- From:
- Omar Polo <op@omarpolo.com>
- Date:
fix `amused add' failure introduced in previous commit
don't advance the files pointer, we need the original pointer when
receiving the replies.
- Commit:
fad0fb69c1b7616f933c497887967078ff4dd111
- From:
- Omar Polo <op@omarpolo.com>
- Date:
refactor: group imsg handling
the approach with one-function-per-imsg leads to too much code
splatted across the file.
- Commit:
90122a37e6f55f08fd979f7b07ba20a49952faf8
- From:
- Omar Polo <op@omarpolo.com>
- Date:
amused monitor: allow to pass a list of event as filter
it's easier / simpler for scripts to do
$ amused monitor next,prev,jump
rather than
$ amused monitor | egrep --line-buffered 'next|prev|jump'
- Commit:
d51201063dfd08d55382bc1848cee7f4662f504b
- From:
- Omar Polo <op@omarpolo.com>
- Date:
add back missing memzero
- Commit:
1dd3b054dd3d8778debf24bb32cc61ff06e3ee42
- From:
- Omar Polo <op@omarpolo.com>
- Date:
use a more readable strncmp to look for prefixes
also while here stick an `else' before the second clausole. We're
supposed to trim out only '> ' and ' ', but the missing else would
also trim out ' ' after a '> '!
- Commit:
c00c1428ccaedc2d63d9d489c00d796d5718f615
- From:
- Omar Polo <op@omarpolo.com>
- Date:
get rid of realpath during load
it has a non-ignorable cost over NFS (sdk@ reported ~30 seconds to load
64k songs, and up to 5 minutes over wifi!) and don't provide us any real
gain: files can still vanish after being imported or may appear later.
The only advantage of realpath was that it would clean up the path from
segments like "/./" and resolve the ".." components, but that's a minor
issue anyway.
prodded by, discussed with and tested by sdk@, thanks a lot!
- Commit:
335fa83ad847d6b5b891ec166625907be664ab5d
- From:
- Omar Polo <op@omarpolo.com>
- Date:
drop now unused #include <sndio.h>
with the recent refactoring, sndio is only visible in player.c
- Commit:
acaf7eb251046be1f73077acf6519aa7496fa0a4
- From:
- Omar Polo <op@omarpolo.com>
- Date:
fix argc check
argc can be -1 if we called noarg with argc=0, because optind is 1.
- Commit:
7e29fc4a3e7217cea06735afda36eac20159ae18
- From:
- Omar Polo <op@omarpolo.com>
- Date:
correctly handle arguments for sub-commands
things like "--" should be skipped etc, easier to rely on getopt(3).
- Commit:
f44b3c4e5f075af1be265b896f3fcb320c831ad8
- From:
- Omar Polo <op@omarpolo.com>
- Date:
output the two repeat bits in two different lines
- Commit:
54f55296abf2a40f2c21a89e621ef7af59515b32
- From:
- Omar Polo <op@omarpolo.com>
- Date:
ctl_noarg: allow argv == 0 for the implicit "status" case