Commits

Commit:
afd3149814241c83780b6f8df65ea0cfa39fbcb8
From:
Stefan Sperling <stsp@stsp.name>
Date:
fix a harmless off-by-one from previous commit
diff | patch | tree
Commit:
a5e587e014cba0e9dc62ab1817983c89851cbe93
From:
Stefan Sperling <stsp@stsp.name>
Date:
fix a bug in got_privsep_send_object_idlist() exposed by recent changes The old code did not work correctly if only a single object Id was to be sent to got-read-pack. Make got-read-pack error out if the list of commits for object enumeration is empty to catch this problem if it occurs again. Found by the send_basic test, which was failing with GOT_TEST_PACK=1 ok tracey
diff | patch | tree
Commit:
db9b9b1c2b70d98419e70b05e7283b2284bedbec
From:
Stefan Sperling <stsp@stsp.name>
Date:
let got-read-pack be explicit about whether it could enumerate all objects This allows the main process to avoid looping over all object IDs again in case the pack file used for enumeration is complete. ok op@
diff | patch | tree
Commit:
b4b1b9c0333d1aedca89dd35c4e60ac8684cddac
From:
Omar Polo <op@omarpolo.com>
Date:
remove trailing whitespaces
diff | patch | tree
Commit:
0fca100c2fe2bfd8e88b22246068addedecd343d
From:
Omar Polo <op@omarpolo.com>
Date:
compute object size, not pointer size in this case they're luckily the same; got_imsg_object_idlist and got_imsg_reused_delta only have one size_t long field. ok stsp@
diff | patch | tree
Commit:
c98b0f0b57cce101941efd993eac8b9e3be2a70a
From:
Omar Polo <op@omarpolo.com>
Date:
strictier validation for data received from libexec helpers use correct error code and ok stsp@
diff | patch | tree
Commit:
3e6054c427d642654d5abed63965eead037a7b2f
From:
Omar Polo <op@omarpolo.com>
Date:
drop unused variable
diff | patch | tree
Commit:
bf31a716e240db9b58ddd53f468b3b23e49237c2
From:
Omar Polo <op@omarpolo.com>
Date:
use strndup instead of malloc+memcpy Simplifies the reading of the author/committer string and makes also the code shorter. ok stsp@
diff | patch | tree
Commit:
71fee5a34a12ea7a545b3c4dfbe91023c8f7c69a
From:
Omar Polo <op@omarpolo.com>
Date:
don't check datalen when calling recv_imsg_error recv_imsg_error already checks the size of the message, and it does so more precisely than the removed code. ok stsp@
diff | patch | tree
Commit:
0ab4c95723904e176687f5edc131bdf422dd261a
From:
Stefan Sperling <stsp@stsp.name>
Date:
Bring back object enumeration inside got-read-pack as a fast path. The problem that was found in the earlier version has been fixed. ok op@
diff | patch | tree
Commit:
e44d939152693c16e95d2855b539ad6b30e81b15
From:
Stefan Sperling <stsp@stsp.name>
Date:
revert object enumeration in got-read-pack for now; needs more work This implementation marked commits and trees as enumerated before all trees which they depend on were enumerated. This behaviour leads to incomplete pack files when a tree is only partially packed and got-read-pack hits a missing tree entry as a result. The algorithm must be reworked such that packed leave nodes are marked enumerated first, then bubble-up. Found by op@
diff | patch | tree
Commit:
f09728336c4d35bfa49210e640b1ceb8989fe3d5
From:
Stefan Sperling <stsp@stsp.name>
Date:
fix wrong line wrap; pointed out by op@
diff | patch | tree
Commit:
876f8c1a29bce31fa6d99470a60be90c724ec4b6
From:
Stefan Sperling <stsp@stsp.name>
Date:
imsg_add() already frees wbuf on error; pointed out by op@
diff | patch | tree
Commit:
cee6a7ea556f9f3ae0f50df959c2acd8cb59bf80
From:
Stefan Sperling <stsp@stsp.name>
Date:
implement object enumeration support in got-read-pack ok op@
diff | patch | tree
Commit:
c9b75c7bd7036a6895bbc3eba2ed0369238ebab4
From:
Stefan Sperling <stsp@stsp.name>
Date:
revert "Skip poll(2) if an imsgbuf has a non-empty read buffer" imsg_read() will call recvmsg() on the file descriptor regardless of the read buffer's state, so we should ensure that data is ready. The read buffer is used by imsg_get(), not imsg_read(). We already call imsg_get() before imsg_read(), and call the latter only if imsg_get() returns zero.
diff | patch | tree