Commits
- Commit:
dc12484b39eaa5dc5d853206cf08905ef29a93e8
- From:
- Omar Polo <op@omarpolo.com>
- Date:
typo in 'repeat'
- Commit:
bdc8c4e0629b2e694e711b290be897f85e9ce08f
- From:
- Omar Polo <op@omarpolo.com>
- Date:
print the duration and position
- Commit:
1b77ad485132dd80c7671fc8119cc0c6dc00d6e1
- From:
- Omar Polo <op@omarpolo.com>
- Date:
don't loop indefinitely in ctl_connect
if the server fails to start for wathever reason, we end up looping in
ctl_connect indefinitely as we try to spawn the deamon (that dies) and
try to connect to it.
Add an arbitrary maximum number of retries before giving up.
Reported by sikmir in the GitHub issue #1, thanks!
- Commit:
f1beb69a5a32a1c46d84321029896360dbc8a0b0
- From:
- Omar Polo <op@omarpolo.com>
- Date:
use log_warn to report the failure of canonpath
- Commit:
18223c2807bc7cc41327d84c187934fd2730d277
- From:
- Omar Polo <op@omarpolo.com>
- Date:
reset path buffer before writing to it
otherwise path, which is filled by the garbage that's on the stack, may
not end with a NUL byte. main_enqueue fails with "malformed data" if
the path sent doesn't end with a NUL.
(i.e. the fact that in every case the path is NUL-terminated is not
relevant. For semplicity, I'm working with paths long PATH_MAX bytes
and only checking that path[PATH_MAX-1] is NUL when handling the imsgs.)
Issue reported by Dirk-Wilhelm Peters, thanks!
- Commit:
a830518b711387c072755100b8c6d9142b19656e
- From:
- Omar Polo <op@omarpolo.com>
- Date:
use a strictier pledge for `amused add'
now that we're using canonpath instead of realpath(3), we can drop the
rpath pledge promise.
- Commit:
ef593b43ed4d545943bfb6ebdcc0b8a9c9450cd1
- From:
- Omar Polo <op@omarpolo.com>
- Date:
use canonpath instead of realpath(3)
so we get the same behaviour with `add' and `load'
- Commit:
96233476c269f24ce76cecadc2f5144632157d7b
- From:
- Omar Polo <op@omarpolo.com>
- Date:
use canonpath (from kern_pledge.c) instead of home grow "equivalent"
- Commit:
d903ec9aae187a608670f040d40a89ca1fed243a
- From:
- Omar Polo <op@omarpolo.com>
- Date:
drop a local variable
don't need to keep `files' around, res->files is enough. it would have
prevented the previous bug (probably.)
- Commit:
a185ed1ea0aa9e48c5cc2708ee45ef4c80bd4277
- From:
- Omar Polo <op@omarpolo.com>
- Date:
fix `amused add' failure introduced in previous commit
don't advance the files pointer, we need the original pointer when
receiving the replies.
- Commit:
fad0fb69c1b7616f933c497887967078ff4dd111
- From:
- Omar Polo <op@omarpolo.com>
- Date:
refactor: group imsg handling
the approach with one-function-per-imsg leads to too much code
splatted across the file.
- Commit:
90122a37e6f55f08fd979f7b07ba20a49952faf8
- From:
- Omar Polo <op@omarpolo.com>
- Date:
amused monitor: allow to pass a list of event as filter
it's easier / simpler for scripts to do
$ amused monitor next,prev,jump
rather than
$ amused monitor | egrep --line-buffered 'next|prev|jump'
- Commit:
d51201063dfd08d55382bc1848cee7f4662f504b
- From:
- Omar Polo <op@omarpolo.com>
- Date:
add back missing memzero
- Commit:
1dd3b054dd3d8778debf24bb32cc61ff06e3ee42
- From:
- Omar Polo <op@omarpolo.com>
- Date:
use a more readable strncmp to look for prefixes
also while here stick an `else' before the second clausole. We're
supposed to trim out only '> ' and ' ', but the missing else would
also trim out ' ' after a '> '!
- Commit:
c00c1428ccaedc2d63d9d489c00d796d5718f615
- From:
- Omar Polo <op@omarpolo.com>
- Date:
get rid of realpath during load
it has a non-ignorable cost over NFS (sdk@ reported ~30 seconds to load
64k songs, and up to 5 minutes over wifi!) and don't provide us any real
gain: files can still vanish after being imported or may appear later.
The only advantage of realpath was that it would clean up the path from
segments like "/./" and resolve the ".." components, but that's a minor
issue anyway.
prodded by, discussed with and tested by sdk@, thanks a lot!