Commits
- Commit:
bbca1adf04e40d91b98c326953a147a37b94c817
- From:
- Omar Polo <op@omarpolo.com>
- Date:
remove unneded wbuf->fd = -1
There's no need to set the fd to -1 on ibufs created with imsg_create(3),
and it was probably never needed.
- Commit:
2c52c623be04b56400a5c94cc8d86b6fda214d16
- From:
- Omar Polo <op@omarpolo.com>
- Date:
convert to use imsg_get_fd()
While here also fix a fd leak in got-read-pack. We were dup'ing
imsg.fd without closing imsg.fd later; instead just use imsg_get_fd()
to extract the file descriptor.
Tested by falsifian and Kyle Ackerman, thanks!
'go ahead' stsp@
- Commit:
510b45554017ce0a907a5c11a24266600eab5783
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
avoid opening objects in the gotd session process for no reason
The session process opened an object as part of a sanity check and
simply closed it again. Opening an object involves decompression
and combination of deltas. Add a new interface which checks whether
an object ID exists without such overhead and call it from gotd.
- Commit:
808264b2482b61d7bab9f3d7b0b4a9703a3942cd
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
make gotd flush pending messages before disconnecting the client upon success
This prevents gotd from closing the client connection before ref-update
status reports have been sent. Seen while testing gotd on Linux, though I
see no obvious reason why this race would not trigger on OpenBSD.
- Commit:
1050403b806ca85666ad4b6a9e83953fdbb5298a
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
gotd: stop logging "unexpected end of file" when a client decides to disconnect
- Commit:
b061482840b244c4645851c4a02a9ce9723b9fc5
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
unveil repositories read-only in gotd session process while serving fetches
ok op@
- Commit:
1df1761f7094815d15b11a908b2132ca58169fea
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
make gotd show relevant commit hashes in error message if ref-updates collide
- Commit:
f8780fee7a5de8db320833efc4a30aa1ad3814e2
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
make gotd avoid re-writing existing ref files when a ref-update is a no-op
- Commit:
baaae61518bf323d22055a3b02fc9e129ee6d567
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
make gotd avoid a "failed to push some refs" error from no-op 'git push'
gotsh was sending errors such as "unexpected end of file" and
"unexpected flush-pkt" to the client when the client disconnected
immediately after receiving reference announcements from the server.
As a result, 'git push' with both sides up-to-date would show an
obscure error message:
= [up to date] main -> main
error: failed to push some refs to 'ssh://example.com/git/repo.git
Now we see:
= [up to date] main -> main
Everything up-to-date
ok jamsek
- Commit:
53bf0b541977b66862040d4b633fb6b5d3a3c6c8
- From:
- Omar Polo <op@omarpolo.com>
- Date:
rename lib/sha1.c to lib/hash.c
It will soon grow functions to deal with sha256 too. stsp@ agrees.
- Commit:
5822e79e39a8777984e08b5d89a8c55d6aa0356d
- From:
- Omar Polo <op@omarpolo.com>
- Date:
include sha2.h too where sha1.h is included
In preparation for wide sha256 support; stsp@ agrees. Change done
mechanically with
find . -iname \*.[cy] -exec sam {} +
X ,x/<sha1\.h>/i/\n#include <sha2.h>
- Commit:
2ec74a9e9c334f3245765a6e6f35b7977f5b420e
- From:
- Omar Polo <op@omarpolo.com>
- Date:
drop double process name from some gotd logs
i.e. "listen: listen: shutting down" -> "listen: shutting down"
the procname is already prepended by vlog()
ok jamsek
- Commit:
3931a8a4404d58250d0d16467474bfba2cc215c2
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
rename a function for clarity
- Commit:
da76b65174488c46bf80a5af7896dfdc3ae60fee
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
zap trailing whitespace
- Commit:
839bbaae43d84a7eb75ef0b327239fd36c360ada
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotd, gotadmin: install packfiles and index files as 0444
gotd used 0600 (due to mkstemps(3)), gotadmin 0644; change it to 0444
since packfiles shouldn't change once created. Mirrors what git does.
ok stsp@