gotwebd: fix some got_error_from_errno2/3 calls it's not printf-like so %s don't make sense. Tweak the order of the arguments to obtain the intended output.

don't zero fields of a calloc()-allocated struct

rename got_gotweb_flushfile -> got_gotweb_closefile suggested and ok millert@

log close() failure in gotweb_free_transport

simplify got_gotweb_openfile/flushfile Return only the FILE *, and require only that to close subsequently. Having to manage the file descriptor too makes using these functions unnecessary complex. millert@ agrees

gotwebd: fix logic error and skip again some entries in the index logic error introduced in df2d3cd25 ok stsp@

gotwebd: don't special case BLOB, BLOBRAW and RSS shuffle some code to handle all the page types in the switch. ok tracey@

gotwebd: reply with non-200 HTTP status code on error ok tracey@

gotwebd: provide gotweb_render_page() entrypoint for all pages simplify gotweb_process_request more, handling all the pages inside the big switch. There's only one entrypoint for rendering the templates gotweb_render_page() that takes the page' content as argument. The only real difference is that gotweb_render_index() now skips directory entries which fails to handle. ok tracey@

include sha2.h too where sha1.h is included In preparation for wide sha256 support; stsp@ agrees. Change done mechanically with find . -iname \*.[cy] -exec sam {} + X ,x/<sha1\.h>/i/\n#include <sha2.h>

gotwebd: gc unused opendir(). ok stsp@

gotwebd: fix briefs/tags navigation overlap Introduces a separate field for the "next" button (now called "More") and adjusted the CSS/HTML so it's used. Finally, drops the old code used to handle the pagination for the BRIEFS/COMMITS cases. Needs a small hack for the time being, setting the action to TAGS. This is due how qs->action is changed in gotweb.c while handling the request. ok jamsek

gotwebd: turn gotweb_get_time_str into gotweb_render_age ok jamsek

gotwebd: refactor gotweb_render_content_type/_file Rework them so that they allow to set the Status header (the HTTP status code; only way since we're behind FastCGI) and optionally a Location. Since they're now unused outside of gotweb.c, mark them as static. They also used to always return NULL so the error is pointless; return the -1 on failure though. While here, rename to gotweb_reply and gotweb_reply_file. ok jamsek

gotwebd: delete now unused code gotweb_escape_html and gotweb_link are now completely unused. ok jamsek