Commit Diff

Commit:
0dd5271bd8f2a4f92ac3536fcc493eebc39b86e5
From:
Stefan Sperling <stsp@stsp.name>
Date:
Message:
plug fd leak in got_pack_stop_privsep_child()
Actions:
Patch | Tree
commit - 2cb49fa8fb84f3a8fc2eb6036a6bd9b64c57e347
commit + 0dd5271bd8f2a4f92ac3536fcc493eebc39b86e5
blob - 94d6d9c26d9c86ef02d96131e1ebabf6fb1e3c39
blob + 5de6375a4acead9c2ad76d03bd677d14c756be17
--- lib/pack.c
+++ lib/pack.c
@@ -496,6 +496,8 @@ got_pack_stop_privsep_child(struct got_pack *pack)
 	if (err)
 		return err;
 	err = got_privsep_wait_for_child(pack->privsep_child->pid);
+	if (close(pack->privsep_child->imsg_fd) != 0 && err == NULL)
+		err = got_error_from_errno();
 	free(pack->privsep_child);
 	pack->privsep_child = NULL;
 	return err;