commit - 57bc7b6dd5c57ab4bde2a20937e5a5c8e7c3a624
commit + 1d765da334af12ddd26b666c0294e0d39f45cbdf
blob - 424716ca93e16a911d4242842be9f4202b9b1f83
blob + bae2f1f3f3e47feb4dc99c8c49dd89349df27dac
--- lib/pack_create.c
+++ lib/pack_create.c
goto done;
} else if (ncolor == COLOR_BLANK) {
struct got_commit_object *commit;
- struct got_object_id *id;
const struct got_object_id_queue *parents;
struct got_object_qid *pid;
- id = got_object_id_dup(qid->id);
- if (id == NULL) {
- err = got_error_from_errno("got_object_id_dup");
- goto done;
- }
if (qcolor == COLOR_KEEP)
- err = got_object_idset_add(keep, id, NULL);
+ err = got_object_idset_add(keep, qid->id, NULL);
else
- err = got_object_idset_add(drop, id, NULL);
- if (err) {
- free(id);
+ err = got_object_idset_add(drop, qid->id, NULL);
+ if (err)
goto done;
- }
- err = got_object_open_as_commit(&commit, repo, id);
- if (err) {
- free(id);
+ err = got_object_open_as_commit(&commit, repo, qid->id);
+ if (err)
goto done;
- }
+
parents = got_object_commit_get_parent_ids(commit);
if (parents) {
STAILQ_FOREACH(pid, parents, entry) {
err = queue_commit_id(&ids, pid->id,
qcolor, repo);
- if (err) {
- free(id);
+ if (err)
goto done;
- }
}
}
got_object_commit_close(commit);