Commit Diff

Commit:
3b33eab3ad8f82f967e201ab77e16ff28cb76e8e
From:
Omar Polo <op@omarpolo.com>
Date:
Message:
TAILQ_REMOVE env and aliases during config_free it's not technically required, since a couple of lines below we free whole host struct, and we don't have code that may use h->{env,aliases} afterwards, but it's nice not to have invalid pointers around. it may bite in the future.
Actions:
Patch | Tree
commit - a6c809551e8dd554898a041a00d13b03a91d77cd
commit + 3b33eab3ad8f82f967e201ab77e16ff28cb76e8e
blob - e04e1723b9bee94fddb8e4e6657c2ae3c8684694
blob + c4777f5a5838cc759d5026b13e2012053fc51aff
--- gmid.c
+++ gmid.c
@@ -281,12 +281,16 @@ free_config(void)
 		}
 
 		TAILQ_FOREACH_SAFE(e, &h->env, envs, te) {
+			TAILQ_REMOVE(&h->env, e, envs);
+
 			free(e->name);
 			free(e->value);
 			free(e);
 		}
 
 		TAILQ_FOREACH_SAFE(a, &h->aliases, aliases, ta) {
+			TAILQ_REMOVE(&h->aliases, a, aliases);
+
 			free(a->alias);
 			free(a);
 		}