Commit Diff

Commit:
7b366981c181847ca7ddee5d703737ad12ee7184
From:
Stefan Sperling <stsp@stsp.name>
Date:
Message:
always free ds->J in got_diffreg()
Actions:
Patch | Tree
commit - 9b98f34bfa03c10a564b345aba418303214a57aa
commit + 7b366981c181847ca7ddee5d703737ad12ee7184
blob - f6a314eee7e4ce1f534ac2595d5e5d189df410fc
blob + e46456db9888c0aaf638fadece6b6b84389ccde7
--- lib/diffreg.c
+++ lib/diffreg.c
@@ -396,8 +396,6 @@ got_diffreg(int *rval, FILE *f1, FILE *f2, int flags,
 	p = reallocarray(ds->J, ds->len[0] + 2, sizeof(*ds->J));
 	if (p == NULL) {
 		err = got_error_from_errno();
-		free(ds->J);
-		ds->J = NULL;
 		goto closem;
 	}
 	ds->J = p;
@@ -428,6 +426,7 @@ got_diffreg(int *rval, FILE *f1, FILE *f2, int flags,
 	    flags))
 		err = got_error_from_errno();
 closem:
+	free(ds->J);
 	free(ds->member);
 	free(ds->class);
 	if (ds->anychange) {