Commit Diff

Commit:
a875589a9d2af343438e8ea0ba7c507db05f5623
From:
Stefan Sperling <stsp@stsp.name>
Date:
Message:
fix locking of packed ref file in got_ref_open()
Actions:
Patch | Tree
commit - 0885ce8fa7d962afa1fe3df90867508016ed48e6
commit + a875589a9d2af343438e8ea0ba7c507db05f5623
blob - 5c4df8d497281a0449a03f78825465da29659553
blob + 3f03033d5a12dcd98b39c6e2535e82d6fe99d0b5
--- lib/reference.c
+++ lib/reference.c
@@ -404,6 +404,7 @@ got_ref_open(struct got_reference **ref, struct got_re
 	    GOT_REF_HEADS, GOT_REF_TAGS, GOT_REF_REMOTES
 	};
 	int i, well_known = is_well_known_ref(refname);
+	struct got_lockfile *lf = NULL;
 
 	*ref = NULL;
 
@@ -435,7 +436,7 @@ got_ref_open(struct got_reference **ref, struct got_re
 		}
 
 		if (lock) {
-			err = got_lockfile_lock(&(*ref)->lf, packed_refs_path);
+			err = got_lockfile_lock(&lf, packed_refs_path);
 			if (err)
 				goto done;
 		}
@@ -444,15 +445,21 @@ got_ref_open(struct got_reference **ref, struct got_re
 		if (f != NULL) {
 			err = open_packed_ref(ref, f, subdirs, nitems(subdirs),
 			    refname);
-			if (fclose(f) != 0 && err == NULL)
-				err = got_error_prefix_errno("fclose");
-			if (err || *ref)
-				goto done;
+			if (!err) {
+				if (fclose(f) != 0) {
+					err = got_error_prefix_errno("fclose");
+					got_ref_close(*ref);
+					*ref = NULL;
+				} else
+					(*ref)->lf = lf;
+			}
 		}
 	}
 done:
 	if (!err && *ref == NULL)
 		err = got_error_not_ref(refname);
+	if (err && lf)
+		got_lockfile_unlock(lf);
 	free(path_refs);
 	return err;
 }