Commit Diff

Commit:
b618111a681d278d0d72fbdb526542bebf8fce02
From:
Omar Polo <op@omarpolo.com>
Date:
Message:
log more details for FastCGI errors add the reported request id if there's a mismatch and both the gai error and the errno value if getnameinfo fails.
Actions:
Patch | Tree
commit - 5f37f9c20d1773ad0b95b16f67a33f75fea326f4
commit + b618111a681d278d0d72fbdb526542bebf8fce02
blob - 0e11d549712cac62522958b34728a8502ee2866e
blob + 8de518a5d56ffd3ae86e1ba763c8680dee0246ed
--- fcgi.c
+++ fcgi.c
@@ -343,8 +343,8 @@ fcgi_read(struct bufferevent *bev, void *d)
 		c = try_client_by_id(recid(&hdr));
 		if (c == NULL) {
 			log_err(NULL,
-			    "got invalid client id from fcgi backend %d",
-			    recid(&hdr));
+			    "got invalid client id %d from fcgi backend %d",
+			    recid(&hdr), fcgi->id);
 			goto err;
 		}
 
@@ -463,7 +463,8 @@ fcgi_req(struct fcgi *f, struct client *c)
 	    NULL, 0,
 	    NI_NUMERICHOST);
 	if (e != 0)
-		fatal("getnameinfo failed");
+		fatal("getnameinfo failed: %s (%s)",
+		    gai_strerror(e), strerror(errno));
 
 	c->next = NULL;