Commit Diff

Commit:
c90732a0e16a2a0046cdd088afc09b28ee2c0ba8
From:
Stefan Sperling <stsp@stsp.name>
Date:
Message:
use local pointer variable to access diff view state
Actions:
Patch | Tree
commit - 4d7951a5f024f6d4b88b3f42b0d90608eb560178
commit + c90732a0e16a2a0046cdd088afc09b28ee2c0ba8
blob - 1d7d880e56757e58e10b3cf12cd6ee90b781b856
blob + f5c84ca62952bd4470712217816ceb634f002bb4
--- tog/tog.c
+++ tog/tog.c
@@ -1232,14 +1232,13 @@ show_diff_view(struct tog_view *view)
 	const struct got_error *err = NULL;
 	int ch, done = 0;
 	int eof, i;
+	struct tog_diff_view_state *state = &view->state.diff;
 
 	view_show(view);
 
 	while (!done) {
-		err = draw_file(view, view->state.diff.f,
-		    &view->state.diff.first_displayed_line,
-		    &view->state.diff.last_displayed_line,
-		    &eof, view->nlines);
+		err = draw_file(view, state->f, &state->first_displayed_line,
+		    &state->last_displayed_line, &eof, view->nlines);
 		if (err)
 			break;
 		nodelay(stdscr, FALSE);
@@ -1251,28 +1250,28 @@ show_diff_view(struct tog_view *view)
 				break;
 			case 'k':
 			case KEY_UP:
-				if (view->state.diff.first_displayed_line > 1)
-					view->state.diff.first_displayed_line--;
+				if (state->first_displayed_line > 1)
+					state->first_displayed_line--;
 				break;
 			case KEY_PPAGE:
 			case KEY_BACKSPACE:
 				i = 0;
 				while (i++ < view->nlines - 1 &&
-				    view->state.diff.first_displayed_line > 1)
-					view->state.diff.first_displayed_line--;
+				    state->first_displayed_line > 1)
+					state->first_displayed_line--;
 				break;
 			case 'j':
 			case KEY_DOWN:
 				if (!eof)
-					view->state.diff.first_displayed_line++;
+					state->first_displayed_line++;
 				break;
 			case KEY_NPAGE:
 			case ' ':
 				i = 0;
 				while (!eof && i++ < view->nlines - 1) {
 					char *line = parse_next_line(
-					    view->state.diff.f, NULL);
-					view->state.diff.first_displayed_line++;
+					    state->f, NULL);
+					state->first_displayed_line++;
 					if (line == NULL)
 						break;
 				}