Commit Diff

Commit:
dda76f1836d14f05a7f1ff0ea0fa2b1d191fce2c
From:
Stefan Sperling <stsp@stsp.name>
Date:
Message:
add another XXX comment; I'm not quite sure what to do about this just yet
Actions:
Patch | Tree
commit - f652ec0c9ce2c00acde72d21174d13a46f822531
commit + dda76f1836d14f05a7f1ff0ea0fa2b1d191fce2c
blob - aada9b64b1c814ae088995b0a4454f6f5e5dc9b7
blob + 726420c12a4d8e5f7135155b6ef2d3cf6c7c8761
--- gotweb/gotweb.c
+++ gotweb/gotweb.c
@@ -3742,6 +3742,11 @@ gw_output_repo_tree(struct gw_trans *gw_trans)
 			goto done;
 	}
 
+	/*
+	 * XXX gw_trans->commit might have already been allocated in
+	 * gw_parse_querystring(); could we more cleanly seperate values
+	 * we received as arguments from values we compute ourselves?
+	 */
 	error = got_object_id_str(&gw_trans->commit, commit_id);
 	if (error)
 		goto done;