Commit Diff

Commit:
e5792992e5d6e73bb379bbfcd69ae2e66afe359d
From:
Omar Polo <op@omarpolo.com>
Date:
Message:
change add_delta to take an off_t instead of size_t. add_delta already calls got_delta_open casting the size_t to off_t, and all the add_delta callers pass an off_t anyway; fixes an implicit off_t truncation. ok stsp@
Actions:
Patch | Tree
commit - fba1620002c2caadd99d922c5e66e0d3676cfbc1
commit + e5792992e5d6e73bb379bbfcd69ae2e66afe359d
blob - 36efe8c30ade7284694bc600951d79771cc42662
blob + b9fe3f13bee15721a2972403a9e9e692dafb6531
--- lib/pack.c
+++ lib/pack.c
@@ -1033,7 +1033,7 @@ read_delta_data(uint8_t **delta_buf, size_t *delta_len
 
 static const struct got_error *
 add_delta(struct got_delta_chain *deltas, off_t delta_offset, size_t tslen,
-    int delta_type, size_t delta_size, size_t delta_data_offset)
+    int delta_type, size_t delta_size, off_t delta_data_offset)
 {
 	struct got_delta *delta;
 
@@ -1076,7 +1076,7 @@ resolve_offset_delta(struct got_delta_chain *deltas,
 	}
 
 	err = add_delta(deltas, delta_offset, tslen, delta_type, delta_size,
-	    delta_data_offset);	/* XXX: off_t vs size_t! */
+	    delta_data_offset);
 	if (err)
 		return err;
 
@@ -1151,7 +1151,7 @@ resolve_ref_delta(struct got_delta_chain *deltas, stru
 	}
 
 	err = add_delta(deltas, delta_offset, tslen, delta_type, delta_size,
-	    delta_data_offset);	/* XXX: off_t vs size_t */
+	    delta_data_offset);
 	if (err)
 		return err;