Commit Diff

Commit:
fa4ffeb3a02c74315e5e4163f485ce5b88e3bf38
From:
Stefan Sperling <stsp@stsp.name>
Date:
Message:
properly flush imsg in send_commit_logmsg()
Actions:
Patch | Tree
commit - 644e44ed862856da15a694b4d3f52f4873f624a3
commit + fa4ffeb3a02c74315e5e4163f485ce5b88e3bf38
blob - 8da8e2c1364c77502fee787dc2228a37acde81ea
blob + f27463409c46e08dacad59956ecfe3d0217b9615
--- lib/privsep.c
+++ lib/privsep.c
@@ -377,6 +377,7 @@ static const struct got_error *
 send_commit_logmsg(struct imsgbuf *ibuf, struct got_commit_object *commit,
     size_t logmsg_len)
 {
+	const struct got_error *err = NULL;
 	size_t offset, remain;
 
 	offset = 0;
@@ -385,17 +386,20 @@ send_commit_logmsg(struct imsgbuf *ibuf, struct got_co
 		size_t n = MIN(MAX_IMSGSIZE - IMSG_HEADER_SIZE, remain);
 
 		if (imsg_compose(ibuf, GOT_IMSG_COMMIT_LOGMSG, 0, 0, -1,
-		    commit->logmsg + offset, n) == -1)
-			return got_error_from_errno();
+		    commit->logmsg + offset, n) == -1) {
+			err = got_error_from_errno();
+			break;
+		}
 
-		if (imsg_flush(ibuf) == -1)
-			return got_error_from_errno();
+		err = flush_imsg(ibuf);
+		if (err)
+			break;
 
 		offset += n;
 		remain -= n;
 	}
 
-	return NULL;
+	return err;
 }
 
 const struct got_error *