commit 220c15d2b746878a943f311e6f66b1480e46491d from: Russ Cox date: Sat Oct 20 17:36:52 2012 UTC fix gcc 4.7 warnings (thanks Tuncer Ayaz) R=rsc http://codereview.appspot.com/6744053 commit - 53527a6e7864f5d681d7140f1403d4d8d42311d5 commit + 220c15d2b746878a943f311e6f66b1480e46491d blob - 862f9434dadcf1aaa82f7810dfbe254cab063cc1 blob + f86c99e316bdc3f1d0a57bedd8f6c60d92100a8e --- src/cmd/acidtypes/stabs.c +++ src/cmd/acidtypes/stabs.c @@ -603,14 +603,13 @@ int stabs2acid(Stab *stabs, Biobuf *b) { volatile int fno, i; - char c, *file, *desc, *p; + char c, *desc, *p; char *volatile dir, *volatile fn, *volatile name; Ftypes *f; Type *t, *tt; StabSym sym; dir = nil; - file = nil; fno = 0; fn = nil; for(i=0; stabsym(stabs, i, &sym)>=0; i++){ @@ -621,8 +620,6 @@ stabs2acid(Stab *stabs, Biobuf *b) if(sym.name){ if(sym.name[0] && sym.name[strlen(sym.name)-1] == '/') dir = sym.name; - else - file = sym.name; } denumber(); fstack = nil; blob - c57a41b020bc45d34b115dbd33b27b514da1b00e blob + 4f111ec358fc0be1d63ec844baefd974c2467b9d --- src/cmd/acme/rows.c +++ src/cmd/acme/rows.c @@ -102,12 +102,10 @@ rowadd(Row *row, Column *c, int x) void rowresize(Row *row, Rectangle r) { - int i, dx, odx, deltax; + int i, deltax; Rectangle or, r1, r2; Column *c; - dx = Dx(r); - odx = Dx(row->r); or = row->r; deltax = r.min.x - or.min.x; row->r = r; blob - 378c3ccb04a3ba7fc3d4865ba168ce12f0cb1033 blob + 1022154dbaadb6c136433391859ab7252f158bc1 --- src/cmd/acme/wind.c +++ src/cmd/acme/wind.c @@ -181,7 +181,7 @@ wintaglines(Window *w, Rectangle r) int winresize(Window *w, Rectangle r, int safe, int keepextra) { - int oy, y, mouseintag, mouseinbody, tagresized; + int oy, y, mouseintag, mouseinbody; Point p; Rectangle r1; @@ -203,9 +203,7 @@ winresize(Window *w, Rectangle r, int safe, int keepex /* If needed, resize & redraw tag. */ y = r1.max.y; - tagresized = 0; if(!safe || !w->tagsafe || !eqrect(w->tag.all, r1)){ - tagresized = 1; textresize(&w->tag, r1, TRUE); y = w->tag.fr.r.max.y; windrawbutton(w); blob - 58d59247bf9dd808345d1b6865241c94cd5f8d32 blob + cb618edee3e3c56a9c395637c4a1931ec6bcd6ca --- src/cmd/auth/dsagen.c +++ src/cmd/auth/dsagen.c @@ -14,11 +14,9 @@ void main(int argc, char **argv) { char *s; - int bits; char *tag; DSApriv *key; - bits = 1024; tag = nil; key = nil; fmtinstall('B', mpfmt); blob - 85fa1583bbc2237bf5b0ef2acbbcc7deb03b83d1 blob + 0d9c48794de860a50bc30a7e5662e9c99e222b49 --- src/cmd/auth/factotum/p9cr.c +++ src/cmd/auth/factotum/p9cr.c @@ -156,7 +156,6 @@ p9crserver(Conv *c) astype = AuthChal; challen = NETCHLEN; }else if(c->proto == &vnc){ - astype = AuthVNC; challen = MAXCHAL; }else{ werrstr("bad proto"); blob - 395f45559c7c5461e0c2fe47c3e2202f50d106d1 blob + 1a47be01d9f9a06a07876812d0b4aee53b53ad0c --- src/cmd/devdraw/x11-get.c +++ src/cmd/devdraw/x11-get.c @@ -56,7 +56,7 @@ _xgetxdata(Memimage *m, Rectangle r) void _xputxdata(Memimage *m, Rectangle r) { - int offset, x, y; + int x, y; uchar *p; Point tp, xdelta, delta; Xmem *xm; @@ -69,10 +69,6 @@ _xputxdata(Memimage *m, Rectangle r) xi = xm->xi; gc = m->chan==GREY1 ? _x.gccopy0 : _x.gccopy; - if(m->depth == 24) - offset = r.min.x & 3; - else - offset = r.min.x & (31/m->depth); delta = subpt(r.min, m->r.min); blob - c9356b54500640974ef8fe54cec84c267c8b2ff6 blob + 8b874030d9b35daae17ca13237851a920ba37742 --- src/cmd/ndb/dn.c +++ src/cmd/ndb/dn.c @@ -462,8 +462,6 @@ getactivity(Request *req) void putactivity(void) { - static ulong lastclean; - if(traceactivity) syslog(0, "dns", "put %d by %d.%d", dnvars.active, getpid(), threadid()); lock(&dnvars.lk); dnvars.active--; @@ -490,7 +488,6 @@ putactivity(void) dnageall(0); /* let others back in */ - lastclean = now; needrefresh = 0; dnvars.mutex = 0; } blob - 4808734813f2d0331008b816be7f3ab29271a210 blob + 3ac83a1fbb8c976c508c38b665e224f4bd32871a --- src/cmd/page/rotate.c +++ src/cmd/page/rotate.c @@ -85,21 +85,18 @@ void interlace(Image *im, Image *tmp, int axis, int n, Image *mask, int gran) { Point p0, p1; - Rectangle r0, r1; + Rectangle r0; r0 = im->r; - r1 = im->r; switch(axis) { case Xaxis: r0.max.x = n; - r1.min.x = n; p0 = (Point){gran, 0}; p1 = (Point){-gran, 0}; break; case Yaxis: default: r0.max.y = n; - r1.min.y = n; p0 = (Point){0, gran}; p1 = (Point){0, -gran}; break; blob - eab268f5c4b14124d35f83a564ab36adf2657d63 blob + e0db5fc6c5502b902f5c259e9aafdbadcaa19a1f --- src/cmd/pic/linegen.c +++ src/cmd/pic/linegen.c @@ -20,7 +20,7 @@ obj *linegen(int type) double dx[500], dy[500]; int ndxy; double nx, ny; - Attr *ap, *chop_ap[4]; + Attr *ap; nx = curx; ny = cury; @@ -133,7 +133,6 @@ obj *linegen(int type) else chop2 = ap->a_val.f; } - chop_ap[chop++] = ap; break; case FILL: battr |= FILLBIT; blob - 98dfbb57b2dc67bb234edd85c45296ab2ff1eaff blob + 082f8ee05e0a6556d146897288145efcf1c8c1c5 --- src/cmd/pic/textgen.c +++ src/cmd/pic/textgen.c @@ -7,8 +7,6 @@ obj *textgen(void) int i, sub, nstr, at, with, hset, invis; double xwith, ywith, h, w, x0, y0, x1, y1; obj *p, *ppos; - static double prevh = 0; - static double prevw = 0; Attr *ap; at = with = nstr = hset = invis = 0; @@ -93,8 +91,6 @@ obj *textgen(void) cury = y1; else cury = y0; - prevh = h; - prevw = w; return(p); } blob - fd3e59b86a40359bff7ae883da7f9e256320b897 blob + c0d02e65dfc1253d8c4cb9fd02abc59e80060853 --- src/cmd/venti/srv/mirrorarenas.c +++ src/cmd/venti/srv/mirrorarenas.c @@ -63,7 +63,7 @@ enum void setstatus(int bits) { - static int startindx = -1, endindx; + static int startindx = -1; static char *startname, *endname; static int lastbits; char buf[100]; @@ -91,16 +91,13 @@ setstatus(int bits) } lastbits = bits; startindx = tagindx; - endindx = tagindx; startname = tagname; endname = tagname; } else { - endindx = tagindx; endname = tagname; } if(bits < 0) { startindx = -1; - endindx = -1; return; } } blob - ff11b596bcedd770772fa2f55624801e2efca664 blob + 7a65b3a8d91224168d7b4563d3e54066285f36ca --- src/libsunrpc/nfs3.c +++ src/libsunrpc/nfs3.c @@ -78,7 +78,7 @@ nfs3statusstr(Nfs3Status x) } static struct { - SunStatus status; + Nfs3Status status; char *msg; } etab[] = { Nfs3ErrNotOwner, "not owner", blob - 4a3000302f91802162555db999dcd5c2c39cd10e blob + 48b6a2ca81e496d703ea55ed2a0f9fb19863d32e --- src/libsunrpc/udp.c +++ src/libsunrpc/udp.c @@ -82,13 +82,11 @@ sunudpread(void *v) static void sunudpwrite(void *v) { - uchar *buf; Arg arg = *(Arg*)v; SunMsgUdp *msg; sendp(arg.csync, 0); - buf = emalloc(UdpMaxRead); while((msg = recvp(arg.creply)) != nil){ if(udpwrite(arg.fd, &msg->udp, msg->msg.data, msg->msg.count) != msg->msg.count) fprint(2, "udpwrite: %r\n"); blob - ce86d146c803a4569c7a67fc5035391ee981f4f6 blob + b69f9ec42b4c68a897c0f8a6656372f0f8ec5466 --- src/libthread/iorw.c +++ src/libthread/iorw.c @@ -164,12 +164,11 @@ _ioread9pmsg(va_list *arg) int fd; void *a; int n; - int r; fd = va_arg(*arg, int); a = va_arg(*arg, void*); n = va_arg(*arg, int); - r = read9pmsg(fd, a, n); + read9pmsg(fd, a, n); return n; } int